From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 07/10] Input - wacom: handle Graphire BT tablets in wacom.ko Date: Thu, 24 Jul 2014 12:58:27 -0700 Message-ID: <20140724195827.GC26752@core.coreip.homeip.net> References: <1406225645-32141-1-git-send-email-benjamin.tissoires@redhat.com> <1406225645-32141-8-git-send-email-benjamin.tissoires@redhat.com> <20140724193509.GB26752@core.coreip.homeip.net> <20140724194352.GB4190@mail.corp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pd0-f175.google.com ([209.85.192.175]:65445 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934176AbaGXT6b (ORCPT ); Thu, 24 Jul 2014 15:58:31 -0400 Content-Disposition: inline In-Reply-To: <20140724194352.GB4190@mail.corp.redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benjamin Tissoires Cc: Jiri Kosina , Ping Cheng , Jason Gerecke , Przemo Firszt , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org On Thu, Jul 24, 2014 at 03:43:52PM -0400, Benjamin Tissoires wrote: > On Jul 24 2014 or thereabouts, Dmitry Torokhov wrote: > > Hi Benjamin, > > > > On Thu, Jul 24, 2014 at 02:14:02PM -0400, Benjamin Tissoires wrote: > > > + } else if (features->type == GRAPHIRE_BT) { > > > + /* Compute distance between mouse and tablet */ > > > + rw = 44 - (data[6] >> 2); > > > + if (rw < 0) > > > + rw = 0; > > > + else if (rw > 31) > > > + rw = 31; > > > > rw = clamp_val(rw, 0, 31); > > > > ? > > could be... > > I'll do the tests and resubmit later the v3. I'll wait a little in case > you have other comments on the other patches :) How about doing it incrementally - the patch is still sound as far as I am concerned. I will wait a bit for other to chime in with comments or acks before applying this series. -- Dmitry