From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yoichi Yuasa <yuasa@linux-mips.org>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] input: Add ROHM BU21023/24 Dual touch support resistive touchscreens
Date: Thu, 31 Jul 2014 10:16:55 -0700 [thread overview]
Message-ID: <20140731171655.GA5631@core.coreip.homeip.net> (raw)
In-Reply-To: <20140731195434.d141b39f3920686485c64191@linux-mips.org>
Hi Yuichi,
On Thu, Jul 31, 2014 at 07:54:34PM +0900, Yoichi Yuasa wrote:
> Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
I few high-level comments:
- please get rid of polling - it is not useful in production mode;
- switch to threaded interrupts so that you do not need to manage
workqueue/work/timers;
- new drivers should use MT-B protocol with proper contact tracking. If device
does not do good job at tracking contacts you can use input's core matching
algorithm (input_mt_assign_slots).
- please provide ST emulation as well (input_mt_report_pointer_emulation).
- the way you requesting firmware in probe path means you need to build
firmware image into kernel or be careful how you pack it to avoid timeouts on
boot. Since the device properties are not changing you might want to postpone
that until somebody tries to open the device.
- please add error handling for IO operations.
- managed resources simplify the code.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-07-31 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 10:54 [PATCH] input: Add ROHM BU21023/24 Dual touch support resistive touchscreens Yoichi Yuasa
2014-07-31 11:54 ` Pramod Gurav
2014-08-01 5:31 ` Yoichi Yuasa
2014-07-31 17:16 ` Dmitry Torokhov [this message]
2014-08-01 10:32 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731171655.GA5631@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=yuasa@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).