Re: [PATCH] input: Add ROHM BU21023/24 Dual touch support resistive touchscreens

[Yoichi Yuasa <yuasa@linux-mips.org>]

Hi Dmitry,

On Thu, 31 Jul 2014 10:16:55 -0700
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> Hi Yuichi,
> 
> On Thu, Jul 31, 2014 at 07:54:34PM +0900, Yoichi Yuasa wrote:
> > Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
> 
> I few high-level comments:
> 
> - please get rid of polling - it is not useful in production mode;
> - switch to threaded interrupts so that you do not need to manage
>   workqueue/work/timers;
> - new drivers should use MT-B protocol with proper contact tracking. If device
>   does not do good job at tracking contacts you can use input's core matching
> algorithm (input_mt_assign_slots).
> - please provide ST emulation as well (input_mt_report_pointer_emulation).
> - the way you requesting firmware in probe path means you need to build
>   firmware image into kernel or be careful how you pack it to avoid timeouts on
>   boot. Since the device properties are not changing you might want to postpone
>   that until somebody tries to open the device.
> - please add error handling for IO operations.
> - managed resources simplify the code.

Thank you for your comments.
I'll try to update.

Thanks,

Yoichi