TSC2004 driver

TSC2004 driver

[Michael Welling]

The TSC2004 driver has yet to appear in the mainline kernel. We have
been using the driver referenced here as provided by TI:

https://www.mail-archive.com/linux-omap@vger.kernel.org/msg22018.html

Are there any plans of supporting this device in the mainline kernel?

Mysteriously a device tree entry was found in the following file:
arch/arm/boot/dts/omap4-var-som-om44.dtsi

This is obviously pointing to an out of tree driver that is not easily
obtained.

Suggestions?

Re: TSC2004 driver

[Dmitry Torokhov]

Hi Michael,

On Tue, Aug 05, 2014 at 12:06:40PM -0500, Michael Welling wrote:
> The TSC2004 driver has yet to appear in the mainline kernel. We have
> been using the driver referenced here as provided by TI:
> 
> https://www.mail-archive.com/linux-omap@vger.kernel.org/msg22018.html
> 
> Are there any plans of supporting this device in the mainline kernel?

I still believe that support for TSC2004 should be added 5to tsc2007, they are
too much alike to be separate drivers.

> 
> Mysteriously a device tree entry was found in the following file:
> arch/arm/boot/dts/omap4-var-som-om44.dtsi
> 
> This is obviously pointing to an out of tree driver that is not easily
> obtained.
> 
> Suggestions?

Thanks.

-- 
Dmitry

Re: TSC2004 driver

[Joachim Eastwood]

On 6 August 2014 21:37, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> Hi Michael,
>
> On Tue, Aug 05, 2014 at 12:06:40PM -0500, Michael Welling wrote:
>> The TSC2004 driver has yet to appear in the mainline kernel. We have
>> been using the driver referenced here as provided by TI:
>>
>> https://www.mail-archive.com/linux-omap@vger.kernel.org/msg22018.html
>>
>> Are there any plans of supporting this device in the mainline kernel?
>
> I still believe that support for TSC2004 should be added 5to tsc2007, they are
> too much alike to be separate drivers.

I tried to add tsc2004 support to the tsc2007 driver but I didn't
really get it to work properly because the tsc2007 interrupt handling
differs from what tsc2004 needs.

I think it would be better to add tsc2004 support to the tsc2005
driver. They only difference between those two chips is the interface
(i2c vs spi). If regmap was added to tsc2005 I think it should be easy
to support tsc2004.

>>
>> Mysteriously a device tree entry was found in the following file:
>> arch/arm/boot/dts/omap4-var-som-om44.dtsi
>>
>> This is obviously pointing to an out of tree driver that is not easily
>> obtained.

I have patches that add tsc2004 support to the tsc2007 driver, but I
really can't recommend them. The interrupt handling is broken so for
each touch event the chip needs to be software reset...

The driver you posted a link to above also has flaw btw.

regards
Joachim Eastwood

>> Suggestions?
>
> Thanks.
>
> --
> Dmitry
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: TSC2004 driver

[Dmitry Torokhov]

On Wed, Aug 06, 2014 at 10:33:18PM +0200, Joachim Eastwood wrote:
> On 6 August 2014 21:37, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > Hi Michael,
> >
> > On Tue, Aug 05, 2014 at 12:06:40PM -0500, Michael Welling wrote:
> >> The TSC2004 driver has yet to appear in the mainline kernel. We have
> >> been using the driver referenced here as provided by TI:
> >>
> >> https://www.mail-archive.com/linux-omap@vger.kernel.org/msg22018.html
> >>
> >> Are there any plans of supporting this device in the mainline kernel?
> >
> > I still believe that support for TSC2004 should be added 5to tsc2007, they are
> > too much alike to be separate drivers.
> 
> I tried to add tsc2004 support to the tsc2007 driver but I didn't
> really get it to work properly because the tsc2007 interrupt handling
> differs from what tsc2004 needs.

OK.

> 
> I think it would be better to add tsc2004 support to the tsc2005
> driver. They only difference between those two chips is the interface
> (i2c vs spi). If regmap was added to tsc2005 I think it should be easy
> to support tsc2004.

That would also be acceptable.

Thanks.

-- 
Dmitry

Re: TSC2004 driver

[Michael Welling]

On Wed, Aug 6, 2014 at 4:16 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, Aug 06, 2014 at 10:33:18PM +0200, Joachim Eastwood wrote:
>> On 6 August 2014 21:37, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>> > Hi Michael,
>> >
>> > On Tue, Aug 05, 2014 at 12:06:40PM -0500, Michael Welling wrote:
>> >> The TSC2004 driver has yet to appear in the mainline kernel. We have
>> >> been using the driver referenced here as provided by TI:
>> >>
>> >> https://www.mail-archive.com/linux-omap@vger.kernel.org/msg22018.html
>> >>
>> >> Are there any plans of supporting this device in the mainline kernel?
>> >
>> > I still believe that support for TSC2004 should be added 5to tsc2007, they are
>> > too much alike to be separate drivers.
>>
>> I tried to add tsc2004 support to the tsc2007 driver but I didn't
>> really get it to work properly because the tsc2007 interrupt handling
>> differs from what tsc2004 needs.
>
> OK.
>
>>
>> I think it would be better to add tsc2004 support to the tsc2005
>> driver. They only difference between those two chips is the interface
>> (i2c vs spi). If regmap was added to tsc2005 I think it should be easy
>> to support tsc2004.
>
> That would also be acceptable.

The tsc2005 still needs devicetree conversion, so it is at least 2 patches away
from where I can use it.

I have missed the window for my companies OE release so I doubt I will
have time to code
in all or any of this.

I am in the process of routing a AM335x SoM which obsoletes this AM3517 one
so my resources will be elsewhere.

>
> Thanks.
>
> --
> Dmitry

Re: TSC2004 driver

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi,

On Wed, Aug 06, 2014 at 05:13:19PM -0500, Michael Welling wrote:
> The tsc2005 still needs devicetree conversion, so it is at least 2
> patches away from where I can use it.

TSC2005 DT support has been added in 3.16:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a38cfebb56898633687ab337fd53710e63a0aedd

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: TSC2004 driver

[Michael Welling]

On Wed, Aug 6, 2014 at 5:28 PM, Sebastian Reichel <sre@kernel.org> wrote:
> Hi,
>
> On Wed, Aug 06, 2014 at 05:13:19PM -0500, Michael Welling wrote:
>> The tsc2005 still needs devicetree conversion, so it is at least 2
>> patches away from where I can use it.
>
> TSC2005 DT support has been added in 3.16:
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a38cfebb56898633687ab337fd53710e63a0aedd

Sorry for the misinformation.

If someone else is volunteering to do the regmap support let me know.

>
> -- Sebastian