From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kiran Padwal <kiran.padwal@smartplayin.com>
Cc: support.opensource@diasemi.com,
anthony.olech.opensource@diasemi.com, david.chen@diasemi.com,
kiran.padwal21@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: da9055_onkey: convert to use devm_*
Date: Fri, 8 Aug 2014 00:42:15 -0700 [thread overview]
Message-ID: <20140808074215.GA10253@core.coreip.homeip.net> (raw)
In-Reply-To: <1407482212-17669-1-git-send-email-kiran.padwal@smartplayin.com>
Hi Kiran,
On Fri, Aug 08, 2014 at 12:46:52PM +0530, Kiran Padwal wrote:
> Converting to devm functions can make the code smaller and cleaner.
Unfortunately it also makes it incorrect. As presented this conversion
introduces race on driver removal. Before doing any more devm conversions
please try to spot it or ping me back in a couple of days if you'd like it
explained.
Thanks.
--
Dmitry
prev parent reply other threads:[~2014-08-08 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 7:16 [PATCH 2/2] Input: da9055_onkey: convert to use devm_* Kiran Padwal
2014-08-08 7:42 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808074215.GA10253@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=anthony.olech.opensource@diasemi.com \
--cc=david.chen@diasemi.com \
--cc=kiran.padwal21@gmail.com \
--cc=kiran.padwal@smartplayin.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).