* [PATCH] Input: atmel_mxt_ts - remove unneeded check
@ 2014-08-17 14:28 Dmitry Torokhov
2014-08-19 18:56 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2014-08-17 14:28 UTC (permalink / raw)
To: linux-input; +Cc: Nick Dyer, Stephen Warren, linux-kernel
This fixes the following issue reported by Coverity:
** CID 1231785: Unsigned compared against 0 (NO_EFFECT)
/drivers/input/touchscreen/atmel_mxt_ts.c: 1157 in mxt_prepare_cfg_mem()
The variable 'byte_offset' is declared as unsigned int and therefore can never
be less than 0.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/atmel_mxt_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index db178ed..8780c9a 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -1154,7 +1154,7 @@ static int mxt_prepare_cfg_mem(struct mxt_data *data,
byte_offset = reg + i - cfg_start_ofs;
- if (byte_offset >= 0 && byte_offset < config_mem_size) {
+ if (byte_offset < config_mem_size) {
*(config_mem + byte_offset) = val;
} else {
dev_err(dev, "Bad object: reg:%d, T%d, ofs=%d\n",
--
2.1.0.rc2.206.gedb03e5
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: atmel_mxt_ts - remove unneeded check
2014-08-17 14:28 [PATCH] Input: atmel_mxt_ts - remove unneeded check Dmitry Torokhov
@ 2014-08-19 18:56 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2014-08-19 18:56 UTC (permalink / raw)
To: linux-input; +Cc: Nick Dyer, Stephen Warren, linux-kernel
On Sun, Aug 17, 2014 at 07:28:52AM -0700, Dmitry Torokhov wrote:
> This fixes the following issue reported by Coverity:
>
> ** CID 1231785: Unsigned compared against 0 (NO_EFFECT)
> /drivers/input/touchscreen/atmel_mxt_ts.c: 1157 in mxt_prepare_cfg_mem()
>
> The variable 'byte_offset' is declared as unsigned int and therefore can never
> be less than 0.
>
Withdrawn - Linus recommended to become intimate with the compiler instead.
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index db178ed..8780c9a 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -1154,7 +1154,7 @@ static int mxt_prepare_cfg_mem(struct mxt_data *data,
>
> byte_offset = reg + i - cfg_start_ofs;
>
> - if (byte_offset >= 0 && byte_offset < config_mem_size) {
> + if (byte_offset < config_mem_size) {
> *(config_mem + byte_offset) = val;
> } else {
> dev_err(dev, "Bad object: reg:%d, T%d, ofs=%d\n",
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-19 18:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-17 14:28 [PATCH] Input: atmel_mxt_ts - remove unneeded check Dmitry Torokhov
2014-08-19 18:56 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).