From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ted Mielczarek <ted@mielczarek.org>
Cc: linux-input@vger.kernel.org, paul.gortmaker@windriver.com,
hor27@gmail.com, petr@scssoft.com, magissia@magissia.com,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] Support Xbox One controllers in xpad driver.
Date: Sun, 17 Aug 2014 09:20:22 -0700 [thread overview]
Message-ID: <20140817162022.GA17367@core.coreip.homeip.net> (raw)
In-Reply-To: <1407509169-6849-1-git-send-email-ted@mielczarek.org>
On Fri, Aug 08, 2014 at 10:46:09AM -0400, Ted Mielczarek wrote:
> Xbox One controllers require an initialization message to start sending data,
> so xpad_init_output becomes a required function. The Xbox One controller does
> not have LEDs like the Xbox 360 controller, so that functionality is not
> implemented. The format of messages controlling rumble is currently
> undocumented, so rumble support is not yet implemented.
>
> The only thing I'm not certain about in this patch is the check against bInterfaceNumber in xpad_probe. The Xbox One controller advertises three interfaces with the same interface class, subclass and protocol, and I couldn't see any way to match just the first one using usb_device_id.
>
> Signed-off-by: Ted Mielczarek <ted@mielczarek.org>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2014-08-17 21:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 14:46 [RESEND PATCH] Support Xbox One controllers in xpad driver Ted Mielczarek
2014-08-17 16:20 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140817162022.GA17367@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=hor27@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magissia@magissia.com \
--cc=paul.gortmaker@windriver.com \
--cc=petr@scssoft.com \
--cc=ted@mielczarek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).