From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RESEND PATCH 1/7] mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC Date: Thu, 21 Aug 2014 14:37:47 +0100 Message-ID: <20140821133747.GJ4266@lee--X1> References: <1408536812-7836-1-git-send-email-javier.martinez@collabora.co.uk> <1408536812-7836-2-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1408536812-7836-2-git-send-email-javier.martinez@collabora.co.uk> Sender: linux-samsung-soc-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Wolfram Sang , Dmitry Torokhov , Doug Anderson , Simon Glass , Bill Richardson , Andrew Bresticker , Derek Basehore , Todd Broch , Olof Johansson , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-samsung-soc@vger.kernel.org List-Id: linux-input@vger.kernel.org On Wed, 20 Aug 2014, Javier Martinez Canillas wrote: > From: Doug Anderson >=20 > If someone sends a EC_CMD_REBOOT_EC to the EC, the EC will likely be > unresponsive for quite a while. Add a delay to the end of the comman= d > to prevent random failures of future commands. >=20 > NOTES: > * This could be optimized a bit by simply delaying the next command > sent, but EC_CMD_REBOOT_EC is such a rare command that the extra > complexity doesn't seem worth it. > * This is a bit of an "ugly hack" since the SPI driver is effectively > snooping on the communication and making a lot of assumptions. It > would be nice to architect in some better solution long term. Are you planning on doing that? > * This same logic probably needs to be applied to the i2c driver. >=20 > Signed-off-by: Doug Anderson > Reviewed-by: Randall Spangler > Reviewed-by: Vadim Bendebury > Signed-off-by: Javier Martinez Canillas > --- > drivers/mfd/cros_ec_spi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) I'm willing to accept this as a stand-in. Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog