From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RESEND PATCH 3/7] mfd: cros_ec: stop calling ->cmd_xfer() directly Date: Thu, 21 Aug 2014 15:08:21 +0100 Message-ID: <20140821140821.GK4266@lee--X1> References: <1408536812-7836-1-git-send-email-javier.martinez@collabora.co.uk> <1408536812-7836-4-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ig0-f177.google.com ([209.85.213.177]:51738 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755046AbaHUOI2 (ORCPT ); Thu, 21 Aug 2014 10:08:28 -0400 Received: by mail-ig0-f177.google.com with SMTP id hn18so12901736igb.16 for ; Thu, 21 Aug 2014 07:08:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1408536812-7836-4-git-send-email-javier.martinez@collabora.co.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Javier Martinez Canillas Cc: Wolfram Sang , Dmitry Torokhov , Doug Anderson , Simon Glass , Bill Richardson , Andrew Bresticker , Derek Basehore , Todd Broch , Olof Johansson , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-samsung-soc@vger.kernel.org On Wed, 20 Aug 2014, Javier Martinez Canillas wrote: > From: Andrew Bresticker >=20 > Instead of having users of the ChromeOS EC call the interface-specifi= c > cmd_xfer() callback directly, introduce a central cros_ec_cmd_xfer() > to use instead. This will allow us to put all the locking and retry > logic in one place instead of duplicating it across the different > drivers. >=20 > Signed-off-by: Andrew Bresticker > Reviewed-by: Simon Glass > Signed-off-by: Javier Martinez Canillas > --- > drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +- > drivers/input/keyboard/cros_ec_keyb.c | 2 +- > drivers/mfd/cros_ec.c | 7 +++++++ > include/linux/mfd/cros_ec.h | 24 ++++++++++++++++++-----= - > 4 files changed, 27 insertions(+), 8 deletions(-) Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html