* [PATCH v2] doc: dt/bindings: input: Fix drv260x binding document
@ 2014-08-22 17:12 Dan Murphy
2014-08-22 17:16 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Dan Murphy @ 2014-08-22 17:12 UTC (permalink / raw)
To: devicetree, linux-input
Cc: linux-kernel, dmitry.torokhov, linux-arm-kernel, Dan Murphy
Update the drv260x dt binding document:
- Change the node name to the devices function not the
device name.
- Add vbat-supply to the example.
- Fix indentation of the example.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
v2 - Address comments on indentation, node declaration, add vbat-supply,
removed description as it did not make sense - https://patchwork.kernel.org/patch/4765141/
.../devicetree/bindings/input/ti,drv260x.txt | 23 ++++++++++----------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
index a9c8519..ee09c8f 100644
--- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
+++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
@@ -1,6 +1,4 @@
-Texas Instruments - drv260x Haptics driver family
-
-The drv260x family serial control bus communicates through I2C protocols
+* Texas Instruments - drv260x Haptics driver family
Required properties:
- compatible - One of:
@@ -37,15 +35,16 @@ Optional properties:
3.2 v.
Example:
-drv2605l: drv2605l@5a {
- compatible = "ti,drv2605l";
- reg = <0x5a>;
- enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
- mode = <DRV260X_LRA_MODE>;
- library-sel = <DRV260X_LIB_LRA>;
- vib-rated-mv = <3200>;
- vib-overdriver-mv = <3200>;
-};
+haptics: haptics@5a {
+ compatible = "ti,drv2605l";
+ reg = <0x5a>;
+ vbat-supply = <&vbat>;
+ enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+ mode = <DRV260X_LRA_MODE>;
+ library-sel = <DRV260X_LIB_LRA>;
+ vib-rated-mv = <3200>;
+ vib-overdriver-mv = <3200>;
+}
For more product information please see the link below:
http://www.ti.com/product/drv2605
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] doc: dt/bindings: input: Fix drv260x binding document
2014-08-22 17:12 [PATCH v2] doc: dt/bindings: input: Fix drv260x binding document Dan Murphy
@ 2014-08-22 17:16 ` Felipe Balbi
2014-08-26 22:45 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2014-08-22 17:16 UTC (permalink / raw)
To: Dan Murphy
Cc: devicetree, linux-input, linux-kernel, dmitry.torokhov,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 2275 bytes --]
On Fri, Aug 22, 2014 at 12:12:19PM -0500, Dan Murphy wrote:
> Update the drv260x dt binding document:
> - Change the node name to the devices function not the
> device name.
> - Add vbat-supply to the example.
> - Fix indentation of the example.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
> ---
>
> v2 - Address comments on indentation, node declaration, add vbat-supply,
> removed description as it did not make sense - https://patchwork.kernel.org/patch/4765141/
>
> .../devicetree/bindings/input/ti,drv260x.txt | 23 ++++++++++----------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
> index a9c8519..ee09c8f 100644
> --- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
> +++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
> @@ -1,6 +1,4 @@
> -Texas Instruments - drv260x Haptics driver family
> -
> -The drv260x family serial control bus communicates through I2C protocols
> +* Texas Instruments - drv260x Haptics driver family
>
> Required properties:
> - compatible - One of:
> @@ -37,15 +35,16 @@ Optional properties:
> 3.2 v.
> Example:
>
> -drv2605l: drv2605l@5a {
> - compatible = "ti,drv2605l";
> - reg = <0x5a>;
> - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> - mode = <DRV260X_LRA_MODE>;
> - library-sel = <DRV260X_LIB_LRA>;
> - vib-rated-mv = <3200>;
> - vib-overdriver-mv = <3200>;
> -};
> +haptics: haptics@5a {
> + compatible = "ti,drv2605l";
> + reg = <0x5a>;
> + vbat-supply = <&vbat>;
> + enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> + mode = <DRV260X_LRA_MODE>;
> + library-sel = <DRV260X_LIB_LRA>;
> + vib-rated-mv = <3200>;
> + vib-overdriver-mv = <3200>;
> +}
>
> For more product information please see the link below:
> http://www.ti.com/product/drv2605
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] doc: dt/bindings: input: Fix drv260x binding document
2014-08-22 17:16 ` Felipe Balbi
@ 2014-08-26 22:45 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2014-08-26 22:45 UTC (permalink / raw)
To: Felipe Balbi
Cc: Dan Murphy, devicetree, linux-input, linux-kernel,
linux-arm-kernel
On Fri, Aug 22, 2014 at 12:16:41PM -0500, Felipe Balbi wrote:
> On Fri, Aug 22, 2014 at 12:12:19PM -0500, Dan Murphy wrote:
> > Update the drv260x dt binding document:
> > - Change the node name to the devices function not the
> > device name.
> > - Add vbat-supply to the example.
> > - Fix indentation of the example.
> >
> > Signed-off-by: Dan Murphy <dmurphy@ti.com>
>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-26 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 17:12 [PATCH v2] doc: dt/bindings: input: Fix drv260x binding document Dan Murphy
2014-08-22 17:16 ` Felipe Balbi
2014-08-26 22:45 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).