From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Hawkes <hawkes@google.com>
Subject: Re: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown
Date: Mon, 25 Aug 2014 09:55:52 +0200 [thread overview]
Message-ID: <20140825075552.GA298@x4> (raw)
In-Reply-To: <alpine.LNX.2.00.1408250249150.23162@pobox.suse.cz>
On 2014.08.25 at 02:50 -0500, Jiri Kosina wrote:
> On Fri, 22 Aug 2014, Benjamin Tissoires wrote:
>
> > Commit "HID: logitech: perform bounds checking on device_id early
> > enough" unfortunately leaks some errors to dmesg which are not real
> > ones:
> > - if the report is not a DJ one, then there is not point in checking
> > the device_id
> > - the receiver (index 0) can also receive some notifications which
> > can be safely ignored given the current implementation
> >
> > Move out the test regarding the report_id and also discards
> > printing errors when the receiver got notified.
> >
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> I have now queued this one for 3.17. Adding Markus to CC -- Markus, this
> should make the spurious error messages you have reported go away.
Indeed it does. Feel free to add:
Reported-and-tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
--
Markus
next prev parent reply other threads:[~2014-08-25 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 20:16 [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown Benjamin Tissoires
2014-08-22 20:16 ` [PATCH 2/2] HID: logitech-dj: break out testing of validity of dj_device Benjamin Tissoires
2014-08-25 7:51 ` Jiri Kosina
2014-08-27 21:06 ` Jiri Kosina
2014-08-25 7:50 ` [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown Jiri Kosina
2014-08-25 7:55 ` Markus Trippelsdorf [this message]
2014-08-25 8:00 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825075552.GA298@x4 \
--to=markus@trippelsdorf.de \
--cc=benjamin.tissoires@redhat.com \
--cc=hawkes@google.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).