From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ulrik De Bie <ulrik.debie-os@e2big.org>
Cc: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
David Herrmann <dh.herrmann@gmail.com>
Subject: Re: [PATCH 1/1] Input: elantech: Correct the sign of the x/y movement for trackpoint
Date: Tue, 26 Aug 2014 15:45:22 -0700 [thread overview]
Message-ID: <20140826224521.GA8377@core.coreip.homeip.net> (raw)
In-Reply-To: <1409081423-2259-1-git-send-email-ulrik.debie-os@e2big.org>
Hi Ulrik,
On Tue, Aug 26, 2014 at 09:30:23PM +0200, Ulrik De Bie wrote:
> Hi Dmitry,
>
> Thank you for your feedback !
>
> The x/y movement calculation was wrong, probably caused by my wrong
> documentation at the beginning of the elantech_report_trackpoint
> function. When applying this patch to your patch, it works.
Thank you for testing and providing both the original patch and the
fixup. I folded everything together and applied, I'll try to get it in
3.17.
Thanks!
--
Dmitry
next prev parent reply other threads:[~2014-08-26 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 18:18 [PATCH RESEND v4 0/2] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530 Ulrik De Bie
2014-08-20 18:18 ` [PATCH RESEND v4 1/2] elantech: Add support for trackpoint found on some v3 models Ulrik De Bie
2014-08-24 22:14 ` Dmitry Torokhov
2014-08-26 19:30 ` [PATCH 1/1] Input: elantech: Correct the sign of the x/y movement for trackpoint Ulrik De Bie
2014-08-26 22:45 ` Dmitry Torokhov [this message]
2014-08-20 18:18 ` [PATCH RESEND v4 2/2] elantech: Call psmouse_reset when elantech probe fails Ulrik De Bie
2014-08-23 0:11 ` Dmitry Torokhov
2014-08-21 18:04 ` [PATCH RESEND v4 0/2] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530 Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826224521.GA8377@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dh.herrmann@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=ulrik.debie-os@e2big.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).