linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <btissoir@redhat.com>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Peter Hutterer <peter.hutterer@redhat.com>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 0/2] input: Add INPUT_PROP_POINTING_STICK property
Date: Tue, 2 Sep 2014 10:34:13 -0400	[thread overview]
Message-ID: <20140902143413.GA25423@mail.corp.redhat.com> (raw)
In-Reply-To: <CANq1E4TU9Q3eWm25LhySk28de7r4tjZTLaCMHLOfVo738fnoFg@mail.gmail.com>

Hi David,

On Sep 02 2014 or thereabouts, David Herrmann wrote:
> Hi
> 
> On Tue, Sep 2, 2014 at 2:43 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > Hi,
> >
> > It is useful for userspace to know that they're not dealing with a regular
> > mouse but rather with a pointing stick (e.g. a trackpoint) so that userspace
> > can e.g. automatically enable middle button scrollwheel emulation.
> >
> > It is impossible to tell the difference from the evdev info without resorting
> > to putting a list of device / driver names in userspace, this is undesirable.
> 
> ..so it is better to put that table into the kernel?
> 
> I thought the plan was to avoid putting more hardware tables into the
> kernel. All those tables are always loaded into RAM, whereas solutions
> like udev hwdb can provide the exact same features in user-space but
> avoid loading it into RAM, except if used. hwdb is pretty nice to
> store information about hardware. It is not meant for configuration or
> volatile data, but rather as read-only lookup table for hardware
> information.

I think you misread Hans in this case. Hans stated:
- if this is not provided by the kernel, we have to create a user space
  table with all old and new future devices
- if we put this in the kernel, then we only have to add this property
  to the few generic drivers which present this feature to the user
  space, and done. See patch 1/2. There is no table in the kernel.

> 
> You could easily extend the hwdb with a trackpoint variable that marks
> specific devices as trackpoints.

I don't think this is reasonable. You will have to review all laptops
with trackstick to add them into this (huge) db.

> 
> Anyhow, if you guys want it in the kernel, go ahead. I just don't see
> the advantage of having it in kernel-space.
> 

Again, it's either 10 lines in the kernel, and we forget about it, or we
have to carry a db which has to be updated with every single different
laptop model available. I am definitively in favor of those 10 lines.

Cheers,
Benjamin

  reply	other threads:[~2014-09-02 14:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 12:43 [PATCH 0/2] input: Add INPUT_PROP_POINTING_STICK property Hans de Goede
2014-09-02 12:43 ` [PATCH 1/2] " Hans de Goede
2014-09-02 14:34   ` Benjamin Tissoires
2014-09-03  3:18   ` Peter Hutterer
2014-09-02 12:43 ` [PATCH 2/2] input/mouse: Add missing POINTER / DIRECT properties to a bunch of drivers Hans de Goede
2014-09-02 14:38   ` Benjamin Tissoires
2014-09-03  3:21     ` Peter Hutterer
2014-09-02 12:55 ` [PATCH 0/2] input: Add INPUT_PROP_POINTING_STICK property David Herrmann
2014-09-02 14:34   ` Benjamin Tissoires [this message]
     [not found]   ` <5405D6D4.4070406@redhat.com>
2014-09-02 14:50     ` David Herrmann
2014-09-03  3:24       ` Peter Hutterer
2014-09-08 21:45 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140902143413.GA25423@mail.corp.redhat.com \
    --to=btissoir@redhat.com \
    --cc=dh.herrmann@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=peter.hutterer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).