From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Lee Jones <lee.jones@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
Doug Anderson <dianders@chromium.org>,
Simon Glass <sjg@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Andrew Bresticker <abrestic@chromium.org>,
Derek Basehore <dbasehore@chromium.org>,
Todd Broch <tbroch@chromium.org>, Olof Johansson <olof@lixom.net>,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 7/7] Input: cros_ec_keyb: Optimize ghosting algorithm.
Date: Wed, 3 Sep 2014 17:06:43 -0700 [thread overview]
Message-ID: <20140904000643.GA8034@core.coreip.homeip.net> (raw)
In-Reply-To: <1408974008-17184-8-git-send-email-javier.martinez@collabora.co.uk>
On Mon, Aug 25, 2014 at 03:40:08PM +0200, Javier Martinez Canillas wrote:
> From: Todd Broch <tbroch@chromium.org>
>
> Previous algorithm was a bit conservative and complicating with
> respect to identifying key ghosting. This CL uses the bitops hamming
> weight function (hweight8) to count the number of matching rows for
> colM & colN. If that number is > 1 ghosting is present.
>
> Additionally it removes NULL keys and our one virtual keypress
> KEY_BATTERY from consideration as these inputs are never physical
> keypresses.
>
> Signed-off-by: Todd Broch <tbroch@chromium.org>
> Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
> Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
> Tested-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2014-09-04 0:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 13:40 [PATCH v2 0/7] Second batch of cleanups for cros_ec Javier Martinez Canillas
2014-08-25 13:40 ` [PATCH v2 1/7] mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC Javier Martinez Canillas
2014-08-25 13:40 ` [PATCH v2 2/7] i2c: i2c-cros-ec-tunnel: Set retries to 3 Javier Martinez Canillas
[not found] ` <1408974008-17184-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-08-25 13:40 ` [PATCH v2 3/7] mfd: cros_ec: stop calling ->cmd_xfer() directly Javier Martinez Canillas
2014-08-25 13:40 ` [PATCH v2 7/7] Input: cros_ec_keyb: Optimize ghosting algorithm Javier Martinez Canillas
2014-09-04 0:06 ` Dmitry Torokhov [this message]
2014-08-25 13:40 ` [PATCH v2 4/7] mfd: cros_ec: move locking into cros_ec_cmd_xfer Javier Martinez Canillas
2014-08-25 13:40 ` [PATCH v2 5/7] mfd: cros_ec: wait for completion of commands that return IN_PROGRESS Javier Martinez Canillas
[not found] ` <20140904083426.GD8257@lee--X1>
2014-09-08 11:39 ` Javier Martinez Canillas
2014-09-08 12:48 ` Lee Jones
2014-09-08 16:16 ` Andrew Bresticker
2014-08-25 13:40 ` [PATCH v2 6/7] mfd: cros_ec: Instantiate sub-devices from device tree Javier Martinez Canillas
[not found] ` <20140904082513.GC8257@lee--X1>
2014-09-08 10:57 ` Javier Martinez Canillas
2014-08-25 17:05 ` [PATCH v2 0/7] Second batch of cleanups for cros_ec Dmitry Torokhov
[not found] ` <20140825170533.GA29350-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2014-08-25 17:28 ` Javier Martinez Canillas
2014-08-25 18:01 ` Dmitry Torokhov
[not found] ` <20140825180152.GA31693-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2014-08-26 8:49 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904000643.GA8034@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=abrestic@chromium.org \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@chromium.org \
--cc=tbroch@chromium.org \
--cc=wfrichar@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).