From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Peter Hutterer <peter.hutterer@redhat.com>,
Benjamin Tissoires <btissoir@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads
Date: Fri, 12 Sep 2014 17:26:29 -0700 [thread overview]
Message-ID: <20140913002629.GA12622@core.coreip.homeip.net> (raw)
In-Reply-To: <1410512912-11609-4-git-send-email-hdegoede@redhat.com>
Hi Hans,
On Fri, Sep 12, 2014 at 11:08:32AM +0200, Hans de Goede wrote:
> +/* Always check for focaltech, this is safe as it uses pnp-id matching */
> + if (psmouse_do_detect(focaltech_detect, psmouse, set_properties) == 0) {
> + if (!set_properties || focaltech_init(psmouse) == 0) {
> + /* Not supported yet, use bare protocol */
> + psmouse_max_proto = PSMOUSE_PS2;
I do not believe we need to muck with psmouse_max_proto here, so I'll
drop it and apply.
Thanks.
> + return PSMOUSE_PS2;
> + }
> + }
> +
> /*
> * We always check for lifebook because it does not disturb mouse
> * (it only checks DMI information).
> --
> 2.1.0
>
--
Dmitry
next prev parent reply other threads:[~2014-09-13 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 9:08 [PATCH v2 0/3] psmouse: Add support for detecting FocalTech PS/2 Hans de Goede
2014-09-12 9:08 ` [PATCH v2 1/3] i8042: Also store the aux firmware id in multi-plexed aux ports Hans de Goede
2014-09-12 9:08 ` [PATCH v2 2/3] psmouse: Add psmouse_matches_pnp_id helper function Hans de Goede
2014-09-12 9:08 ` [PATCH v2 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads Hans de Goede
2014-09-13 0:26 ` Dmitry Torokhov [this message]
2014-09-13 8:10 ` Hans de Goede
2014-09-15 17:39 ` Dmitry Torokhov
2014-09-15 17:42 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140913002629.GA12622@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=btissoir@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=peter.hutterer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).