* [PATCH] Input: palmas-pwrbutton: Fix typo in License
@ 2014-09-15 17:58 Nishanth Menon
2014-09-15 18:00 ` Nishanth Menon
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2014-09-15 17:58 UTC (permalink / raw)
To: Jim Davis, Dmitry Torokhov
Cc: linux-kernel, linux-input, linux-omap, linux-arm-kernel,
Nishanth Menon, Stephen Rothwell
Follow the license string convention indicated in include/linux/module.h
(don't capitalize v).
This fixes following randconfig warning:
FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister'
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Reported thread http://marc.info/?l=linux-input&m=141080223209150&w=2
drivers/input/misc/palmas-pwrbutton.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
index 3f90211..4ed6f78 100644
--- a/drivers/input/misc/palmas-pwrbutton.c
+++ b/drivers/input/misc/palmas-pwrbutton.c
@@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
MODULE_ALIAS("platform:palmas-pwrbutton");
MODULE_DESCRIPTION("Palmas Power Button");
-MODULE_LICENSE("GPL V2");
+MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Texas Instruments Inc.");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License
2014-09-15 17:58 [PATCH] Input: palmas-pwrbutton: Fix typo in License Nishanth Menon
@ 2014-09-15 18:00 ` Nishanth Menon
2014-09-15 21:35 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2014-09-15 18:00 UTC (permalink / raw)
To: Jim Davis, Dmitry Torokhov
Cc: linux-kernel, linux-input, linux-omap, linux-arm-kernel,
Stephen Rothwell
On 09/15/2014 12:58 PM, Nishanth Menon wrote:
> Follow the license string convention indicated in include/linux/module.h
> (don't capitalize v).
>
> This fixes following randconfig warning:
> FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister'
>
Uggh.. forgot to add:
Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton")
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Reported thread http://marc.info/?l=linux-input&m=141080223209150&w=2
>
> drivers/input/misc/palmas-pwrbutton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
> index 3f90211..4ed6f78 100644
> --- a/drivers/input/misc/palmas-pwrbutton.c
> +++ b/drivers/input/misc/palmas-pwrbutton.c
> @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
>
> MODULE_ALIAS("platform:palmas-pwrbutton");
> MODULE_DESCRIPTION("Palmas Power Button");
> -MODULE_LICENSE("GPL V2");
> +MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Texas Instruments Inc.");
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License
2014-09-15 18:00 ` Nishanth Menon
@ 2014-09-15 21:35 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2014-09-15 21:35 UTC (permalink / raw)
To: Nishanth Menon
Cc: Jim Davis, linux-kernel, linux-input, linux-omap,
linux-arm-kernel, Stephen Rothwell
On Mon, Sep 15, 2014 at 01:00:44PM -0500, Nishanth Menon wrote:
> On 09/15/2014 12:58 PM, Nishanth Menon wrote:
> > Follow the license string convention indicated in include/linux/module.h
> > (don't capitalize v).
> >
> > This fixes following randconfig warning:
> > FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister'
> >
> Uggh.. forgot to add:
>
> Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton")
Applied both, thank you.
>
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported-by: Jim Davis <jim.epost@gmail.com>
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> > Reported thread http://marc.info/?l=linux-input&m=141080223209150&w=2
> >
> > drivers/input/misc/palmas-pwrbutton.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
> > index 3f90211..4ed6f78 100644
> > --- a/drivers/input/misc/palmas-pwrbutton.c
> > +++ b/drivers/input/misc/palmas-pwrbutton.c
> > @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
> >
> > MODULE_ALIAS("platform:palmas-pwrbutton");
> > MODULE_DESCRIPTION("Palmas Power Button");
> > -MODULE_LICENSE("GPL V2");
> > +MODULE_LICENSE("GPL v2");
> > MODULE_AUTHOR("Texas Instruments Inc.");
> >
>
> --
> Regards,
> Nishanth Menon
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-15 21:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-15 17:58 [PATCH] Input: palmas-pwrbutton: Fix typo in License Nishanth Menon
2014-09-15 18:00 ` Nishanth Menon
2014-09-15 21:35 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).