From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License Date: Mon, 15 Sep 2014 14:35:26 -0700 Message-ID: <20140915213525.GA13468@core.coreip.homeip.net> References: <1410803937-27022-1-git-send-email-nm@ti.com> <5417294C.2010506@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:56113 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756119AbaIOVff (ORCPT ); Mon, 15 Sep 2014 17:35:35 -0400 Content-Disposition: inline In-Reply-To: <5417294C.2010506@ti.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Nishanth Menon Cc: Jim Davis , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Rothwell On Mon, Sep 15, 2014 at 01:00:44PM -0500, Nishanth Menon wrote: > On 09/15/2014 12:58 PM, Nishanth Menon wrote: > > Follow the license string convention indicated in include/linux/module.h > > (don't capitalize v). > > > > This fixes following randconfig warning: > > FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister' > > > Uggh.. forgot to add: > > Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton") Applied both, thank you. > > > Cc: Stephen Rothwell > > Reported-by: Jim Davis > > Signed-off-by: Nishanth Menon > > --- > > Reported thread http://marc.info/?l=linux-input&m=141080223209150&w=2 > > > > drivers/input/misc/palmas-pwrbutton.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c > > index 3f90211..4ed6f78 100644 > > --- a/drivers/input/misc/palmas-pwrbutton.c > > +++ b/drivers/input/misc/palmas-pwrbutton.c > > @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver); > > > > MODULE_ALIAS("platform:palmas-pwrbutton"); > > MODULE_DESCRIPTION("Palmas Power Button"); > > -MODULE_LICENSE("GPL V2"); > > +MODULE_LICENSE("GPL v2"); > > MODULE_AUTHOR("Texas Instruments Inc."); > > > > -- > Regards, > Nishanth Menon -- Dmitry