From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michael Wright <michaelwr@android.com>
Cc: David Herrmann <dh.herrmann@gmail.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Michael Wright <michaelwr@google.com>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] HID: add new gamepad LED constants
Date: Mon, 15 Sep 2014 14:57:28 -0700 [thread overview]
Message-ID: <20140915215728.GB13468@core.coreip.homeip.net> (raw)
In-Reply-To: <CAON4U=OTzqOYDCeT-rFM8trvD80_kQxirZ+Yu5nOjc84v15XLA@mail.gmail.com>
On Mon, Sep 15, 2014 at 11:03:47AM -0700, Michael Wright wrote:
> > Why not introduce all 8 player LEDs as described in the document? You
> > should be safe increasing LED_MAX to 0x1f.
>
> Wasn't sure if it was safe to bump it since it could potentially break apps
> until they recompile against the new API.
I'd rather we did not add any new input LED definitions but rather
looked into switching to LED subsystem, at least for new LEDs.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-09-15 21:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 3:13 [PATCH] HID: add new gamepad LED constants Michael Wright
2014-09-15 5:07 ` David Herrmann
2014-09-15 18:03 ` Michael Wright
2014-09-15 21:57 ` Dmitry Torokhov [this message]
2014-09-15 22:15 ` David Herrmann
2014-09-15 22:58 ` Dmitry Torokhov
2014-09-15 23:41 ` Michael Wright
2014-09-16 0:54 ` Dmitry Torokhov
2014-09-16 1:02 ` Michael Wright
2014-09-16 2:00 ` simon
2014-09-16 4:06 ` Michael Wright
2014-09-17 1:44 ` Pierre-Loup A. Griffais
2014-09-17 1:56 ` Michael Wright
2014-09-22 21:36 ` Michael Wright
2014-09-23 16:40 ` Dmitry Torokhov
2014-09-16 10:00 ` David Herrmann
2014-09-23 16:37 ` Dmitry Torokhov
2014-09-25 10:26 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915215728.GB13468@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dh.herrmann@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=michaelwr@android.com \
--cc=michaelwr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).