From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 15/22] Input: edt-ft5x06 - Replace strnicmp with strncasecmp Date: Wed, 17 Sep 2014 09:26:08 -0700 Message-ID: <20140917162608.GA25297@core.coreip.homeip.net> References: <1410900696-6481-1-git-send-email-linux@rasmusvillemoes.dk> <1410900696-6481-16-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:33870 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755428AbaIQQ0O (ORCPT ); Wed, 17 Sep 2014 12:26:14 -0400 Content-Disposition: inline In-Reply-To: <1410900696-6481-16-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Rasmus Villemoes Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org On Tue, Sep 16, 2014 at 10:51:29PM +0200, Rasmus Villemoes wrote: > The kernel used to contain two functions for length-delimited, > case-insensitive string comparison, strnicmp with correct semantics > and a slightly buggy strncasecmp. The latter is the POSIX name, so > strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper > for the new strncasecmp to avoid breaking existing users. > > To allow the compat wrapper strnicmp to be removed at some point in > the future, and to avoid the extra indirection cost, do > s/strnicmp/strncasecmp/g. > > Cc: Dmitry Torokhov > Cc: linux-input@vger.kernel.org > Signed-off-by: Rasmus Villemoes Applied, thank you. -- Dmitry