From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] HID: add new gamepad LED constants Date: Tue, 23 Sep 2014 09:40:17 -0700 Message-ID: <20140923164017.GD40700@core.coreip.homeip.net> References: <20140915215728.GB13468@core.coreip.homeip.net> <20140915225809.GA31798@core.coreip.homeip.net> <8227f0fc35950a902241a8e053924ef3.squirrel@mungewell.org> <5418E762.5040802@valvesoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pd0-f173.google.com ([209.85.192.173]:41379 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbaIWQkW (ORCPT ); Tue, 23 Sep 2014 12:40:22 -0400 Received: by mail-pd0-f173.google.com with SMTP id y10so6757782pdj.4 for ; Tue, 23 Sep 2014 09:40:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Michael Wright Cc: "Pierre-Loup A. Griffais" , Simon Wood , David Herrmann , HID CORE LAYER , Michael Wright , Jiri Kosina On Mon, Sep 22, 2014 at 02:36:57PM -0700, Michael Wright wrote: > Just so I can figure out the next steps, are you still convinced that > new LEDs should go in the led subsystem Dmitry? At this point I would really prefer them not be part of input_dev structure. Actually there are patches to convert input core to use generic LEDs for the standard keyboard leds, sadly there is an open question of how to handle access via legacy and the new API together so I was not able to merge it [yet]. Thanks. -- Dmitry