From: Wolfram Sang <wsa@the-dreams.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Doug Anderson <dianders@chromium.org>,
Simon Glass <sjg@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Andrew Bresticker <abrestic@chromium.org>,
Derek Basehore <dbasehore@chromium.org>,
Gwendal Grignou <gwendal@google.com>,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/5] i2c: i2c-cros-ec-tunnel: Set retries to 3
Date: Mon, 29 Sep 2014 11:19:44 +0200 [thread overview]
Message-ID: <20140929091944.GA1559@katana> (raw)
In-Reply-To: <20140929075014.GC5985@lee--X1>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Mon, Sep 29, 2014 at 08:50:14AM +0100, Lee Jones wrote:
> On Mon, 29 Sep 2014, Lee Jones wrote:
>
> > On Thu, 18 Sep 2014, Javier Martinez Canillas wrote:
> >
> > > From: Derek Basehore <dbasehore@chromium.org>
> > >
> > > Since the i2c bus can get wedged on the EC sometimes, set the number of retries
> > > to 3. Since we un-wedge the bus immediately after the wedge happens, this is the
> > > correct fix since only one transfer will fail.
> > >
> > > Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> > > Reviewed-by: Doug Anderson <dianders@chromium.org>
> > > Acked-by: Wolfram Sang <wsa@the-dreams.de>
> > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> > > ---
> > > drivers/i2c/busses/i2c-cros-ec-tunnel.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> >
> > Applied, thanks.
>
> Wolfram,
>
> Do you want a pull-request?
Nope. All fine, there shouldn't be any conflict.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-29 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 15:18 [PATCH v4 0/5] Second batch of cleanups for cros_ec Javier Martinez Canillas
2014-09-18 15:18 ` [PATCH v4 2/5] i2c: i2c-cros-ec-tunnel: Set retries to 3 Javier Martinez Canillas
2014-09-29 7:49 ` Lee Jones
2014-09-29 7:50 ` Lee Jones
2014-09-29 9:19 ` Wolfram Sang [this message]
2014-09-18 15:18 ` [PATCH v4 3/5] mfd: cros_ec: stop calling ->cmd_xfer() directly Javier Martinez Canillas
[not found] ` <1411053538-17237-4-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-09-29 7:50 ` Lee Jones
2014-09-18 15:18 ` [PATCH v4 4/5] mfd: cros_ec: move locking into cros_ec_cmd_xfer Javier Martinez Canillas
[not found] ` <1411053538-17237-5-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-09-29 7:51 ` Lee Jones
[not found] ` <1411053538-17237-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-09-18 15:18 ` [PATCH v4 1/5] mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC Javier Martinez Canillas
2014-09-29 7:49 ` Lee Jones
2014-09-18 15:18 ` [PATCH v4 5/5] mfd: cros_ec: wait for completion of commands that return IN_PROGRESS Javier Martinez Canillas
2014-09-29 7:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929091944.GA1559@katana \
--to=wsa@the-dreams.de \
--cc=abrestic@chromium.org \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gwendal@google.com \
--cc=javier.martinez@collabora.co.uk \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sjg@chromium.org \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).