From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"Cavin, Courtney" <Courtney.Cavin@sonymobile.com>
Subject: Re: [PATCH 1/2] input: Add Qualcomm PM8941 power key driver
Date: Mon, 6 Oct 2014 18:52:51 -0700 [thread overview]
Message-ID: <20141007015141.GG28481@sonymobile.com> (raw)
In-Reply-To: <20141007013001.GD39707@dtor-ws>
On Mon 06 Oct 18:30 PDT 2014, Dmitry Torokhov wrote:
> Hi Bjorn,
>
Hi,
> On Mon, Oct 06, 2014 at 06:12:00PM -0700, Bjorn Andersson wrote:
> > +
> > + rc = devm_request_threaded_irq(&pdev->dev, pwrkey->irq,
> > + NULL, pm8941_pwrkey_irq,
> > + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING |
>
> Do we need to hard-code IRQ flags like this? I'd rather we respect DT
> data.
>
We could "move" it to DT but I don't think there's any other combination of
these flags would make sense. If you insist I can remove it though.
Regards,
Bjorn
next prev parent reply other threads:[~2014-10-07 1:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 1:11 [PATCH 0/2] Qualcomm PM8941 power key driver Bjorn Andersson
2014-10-07 1:12 ` [PATCH 1/2] input: Add " Bjorn Andersson
2014-10-07 1:30 ` Dmitry Torokhov
2014-10-07 1:52 ` Bjorn Andersson [this message]
2014-10-07 2:50 ` Dmitry Torokhov
2014-10-07 9:54 ` Kiran Padwal
2014-10-07 23:30 ` Bjorn Andersson
2014-10-07 23:42 ` Dmitry Torokhov
2014-12-08 22:55 ` Bjorn Andersson
2014-10-07 1:12 ` [PATCH 2/2] input: pm8941-pwrkey: Add DT binding documentation Bjorn Andersson
2014-10-07 18:53 ` Kumar Gala
2014-10-07 9:01 ` [PATCH 0/2] Qualcomm PM8941 power key driver Ivan T. Ivanov
2014-10-07 18:46 ` Bjorn Andersson
2014-10-08 9:50 ` Ivan T. Ivanov
2014-10-24 15:23 ` Bjorn Andersson
2014-10-29 16:07 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007015141.GG28481@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=Courtney.Cavin@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).