From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 1/2] input: Add Qualcomm PM8941 power key driver Date: Mon, 6 Oct 2014 18:52:51 -0700 Message-ID: <20141007015141.GG28481@sonymobile.com> References: <1412644321-27683-1-git-send-email-bjorn.andersson@sonymobile.com> <1412644321-27683-2-git-send-email-bjorn.andersson@sonymobile.com> <20141007013001.GD39707@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from seldrel01.sonyericsson.com ([212.209.106.2]:14505 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752398AbaJGByo (ORCPT ); Mon, 6 Oct 2014 21:54:44 -0400 Content-Disposition: inline In-Reply-To: <20141007013001.GD39707@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Grant Likely , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "Cavin, Courtney" On Mon 06 Oct 18:30 PDT 2014, Dmitry Torokhov wrote: > Hi Bjorn, > Hi, > On Mon, Oct 06, 2014 at 06:12:00PM -0700, Bjorn Andersson wrote: > > + > > + rc = devm_request_threaded_irq(&pdev->dev, pwrkey->irq, > > + NULL, pm8941_pwrkey_irq, > > + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | > > Do we need to hard-code IRQ flags like this? I'd rather we respect DT > data. > We could "move" it to DT but I don't think there's any other combination of these flags would make sense. If you insist I can remove it though. Regards, Bjorn