From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 0/2] Qualcomm PM8941 power key driver
Date: Tue, 7 Oct 2014 11:46:41 -0700 [thread overview]
Message-ID: <20141007184640.GB31125@sonymobile.com> (raw)
In-Reply-To: <1412672510.1027.57.camel@iivanov-dev>
On Tue 07 Oct 02:01 PDT 2014, Ivan T. Ivanov wrote:
>
> Hi Bjorn,
>
> On Mon, 2014-10-06 at 18:11 -0700, Bjorn Andersson wrote:
> > These patches add dt bindings and a device driver for the power key block in
> > the Qualcomm PM8941 pmic.
> >
> > Courtney Cavin (2):
> > input: Add Qualcomm PM8941 power key driver
> > input: pm8941-pwrkey: Add DT binding documentation
> >
> > .../bindings/input/qcom,pm8941-pwrkey.txt | 43 +++++
> > drivers/input/misc/Kconfig | 12 ++
> > drivers/input/misc/Makefile | 1 +
> > drivers/input/misc/pm8941-pwrkey.c | 196 ++++++++++++++++++++
> > 4 files changed, 252 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
> > create mode 100644 drivers/input/misc/pm8941-pwrkey.c
>
> Any reason why we cannot reuse pm8xxx-pwrkey driver? It have been
> converted to regmap already.
>
The boilerplate code is the same, but configuration registers have different
layout and values written in them are different. The pm8xxx block have separate
interrupts for press and release events while pm8941 have one interrupt for
both, so the pm8941 must read out the irq status bits to figure out which event
it was.
Maybe if we introduce some vagueness related to interrupts in the dt binding
documentation for pm8xxx we could simply reuse that binding.
Regards,
Bjorn
next prev parent reply other threads:[~2014-10-07 18:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 1:11 [PATCH 0/2] Qualcomm PM8941 power key driver Bjorn Andersson
2014-10-07 1:12 ` [PATCH 1/2] input: Add " Bjorn Andersson
2014-10-07 1:30 ` Dmitry Torokhov
2014-10-07 1:52 ` Bjorn Andersson
2014-10-07 2:50 ` Dmitry Torokhov
2014-10-07 9:54 ` Kiran Padwal
2014-10-07 23:30 ` Bjorn Andersson
2014-10-07 23:42 ` Dmitry Torokhov
2014-12-08 22:55 ` Bjorn Andersson
2014-10-07 1:12 ` [PATCH 2/2] input: pm8941-pwrkey: Add DT binding documentation Bjorn Andersson
2014-10-07 18:53 ` Kumar Gala
2014-10-07 9:01 ` [PATCH 0/2] Qualcomm PM8941 power key driver Ivan T. Ivanov
2014-10-07 18:46 ` Bjorn Andersson [this message]
2014-10-08 9:50 ` Ivan T. Ivanov
2014-10-24 15:23 ` Bjorn Andersson
2014-10-29 16:07 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007184640.GB31125@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).