From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andreas Bosch <linux@progandy.de>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH v2] Input: alps - fix v4 button press recognition
Date: Wed, 15 Oct 2014 10:45:21 -0700 [thread overview]
Message-ID: <20141015174521.GB1968@dtor-ws> (raw)
In-Reply-To: <1413313685-24405-1-git-send-email-linux@progandy.de>
On Tue, Oct 14, 2014 at 09:08:05PM +0200, Andreas Bosch wrote:
> Since the change to struct input_mt_pos some variables are now bitfields
> instead of integers. Automatic conversion from integer to bitfield entry
> destroys information, therefore enforce boolean interpretation instead.
>
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=1114768
> Fixes: 02d04254a5df ("Input: alps - use struct input_mt_pos to track coordinates")
> Signed-off-by: Andreas Bosch <linux@progandy.de>
Applied, thank you.
> ---
>
> This is the second version of the patch. The first try got mangled
> during the transmission.
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 35a49bf..2b0ae8c 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -835,8 +835,8 @@ static void alps_process_packet_v4(struct psmouse *psmouse)
> f->fingers = alps_process_bitmap(priv, f);
> }
>
> - f->left = packet[4] & 0x01;
> - f->right = packet[4] & 0x02;
> + f->left = !!(packet[4] & 0x01);
> + f->right = !!(packet[4] & 0x02);
>
> f->st.x = ((packet[1] & 0x7f) << 4) | ((packet[3] & 0x30) >> 2) |
> ((packet[0] & 0x30) >> 4);
> --
> 2.1.2
>
--
Dmitry
prev parent reply other threads:[~2014-10-15 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 2:26 [PATCH] Input: alps - fix v4 button press recognition Andreas Bosch
2014-10-14 19:08 ` [PATCH v2] " Andreas Bosch
2014-10-15 17:45 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015174521.GB1968@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux@progandy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).