From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/3] input: alps: Reset mouse before identifying it Date: Wed, 15 Oct 2014 11:00:11 -0700 Message-ID: <20141015180011.GB8625@dtor-ws> References: <1412329392-5580-1-git-send-email-pali.rohar@gmail.com> <201410151453.12115@pali> <20141015174315.GA1968@dtor-ws> <201410151957.37855@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pd0-f170.google.com ([209.85.192.170]:49450 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbaJOSAQ (ORCPT ); Wed, 15 Oct 2014 14:00:16 -0400 Content-Disposition: inline In-Reply-To: <201410151957.37855@pali> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Hans de Goede , Yunkang Tang , Tommy Will , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Oct 15, 2014 at 07:57:37PM +0200, Pali Roh=E1r wrote: > On Wednesday 15 October 2014 19:43:15 Dmitry Torokhov wrote: > > On Wed, Oct 15, 2014 at 02:53:11PM +0200, Pali Roh=E1r wrote: > > > On Tuesday 14 October 2014 08:08:34 Dmitry Torokhov wrote: > > > > On Fri, Oct 03, 2014 at 11:47:59AM +0200, Hans de Goede=20 > wrote: > > > > > Hi, > > > > >=20 > > > > > Thanks for working on this! > > > > >=20 > > > > > On 10/03/2014 11:43 AM, Pali Roh=E1r wrote: > > > > > > On some systems after starting computer function > > > > > > alps_identify() does not detect dual ALPS > > > > > > touchpad+trackstick device correctly and detect only > > > > > > touchpad. > > > > > >=20 > > > > > > Resetting ALPS device before identifiying it fixing > > > > > > this problem and both parts touchpad and trackstick > > > > > > are detected. > > > > > >=20 > > > > > > Signed-off-by: Pali Roh=E1r > > > > > > Tested-by: Pali Roh=E1r > > > > >=20 > > > > > Looks good and seems sensible: > > > > >=20 > > > > > Acked-by: Hans de Goede > > > >=20 > > > > *sigh* I am not really happy about this, as we making boot > > > > longer and longer for people without ALPS touchpads. It > > > > would be better if we only reset the mouse when we knew > > > > we are dealing with ALPS, and even better if we only > > > > reset it when we suspected that we missed trackstick. Any > > > > chance of doing this? > > > >=20 > > > > Thanks. > > >=20 > > > Dmitry, problem is that function check which detecting > > > trackstick does not working when I start my laptop from > > > power-off state and do not reset PS/2 device. But detecting > > > ALPS touchpad looks like working. So if do not like this > > > idea, what about doing something like this in alps_dectect > > > function? > > >=20 > > > int alps_detect(...) > > > { > > > ... > > > /* detect if device is ALPS */ > > > if (alps_identify(...) < 0) > > > return -1; > > > /* now we know that device is ALPS */ > > > if (!(flags & ALPS_DUALPOINT)) { > > > /* reset it and identify again, maybe there is trackstick */ > > > psmouse_reset(...); > > > alps_identify(...); > > > } > > > ... > > > } > > >=20 > > > It will does not affect non ALPS devices (because first > > > identify call will fail), but will affect ALPS devices > > > without trackstick (because identify will be called twice > > > and reset too). > >=20 > > I think this is a step in right direction. Do you know what > > exactly fails in alps_identify() on your box if you do not > > call psmouse_reset? > >=20 > > Thanks. >=20 > Yes, I know. It is failing in alps_probe_trackstick_v3(). It=20 > calls alps_command_mode_read_reg(...) and it returns 0 which=20 > means trackstick is not there. OK, so can we try sticking psmouse_reset() there? This will limit the exposure of the new delay. Thanks. --=20 Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html