* [PATCH] Input: misc: max77693-haptic - fix active state check in disable()
@ 2014-10-15 3:16 Jaewon Kim
2014-10-15 4:17 ` Chanwoo Choi
0 siblings, 1 reply; 4+ messages in thread
From: Jaewon Kim @ 2014-10-15 3:16 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Chanwoo Choi, Jaewon Kim, linux-input
In order to avoid duplicated execution, max77693_haptic_disable()
check disable state. But it was reversed. this patch fix it.
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
drivers/input/misc/max77693-haptic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/max77693-haptic.c b/drivers/input/misc/max77693-haptic.c
index d605db4..7b1fde9 100644
--- a/drivers/input/misc/max77693-haptic.c
+++ b/drivers/input/misc/max77693-haptic.c
@@ -152,7 +152,7 @@ static void max77693_haptic_disable(struct max77693_haptic *haptic)
{
int error;
- if (haptic->enabled)
+ if (!haptic->enabled)
return;
error = max77693_haptic_configure(haptic, false);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Input: misc: max77693-haptic - fix active state check in disable()
2014-10-15 3:16 [PATCH] Input: misc: max77693-haptic - fix active state check in disable() Jaewon Kim
@ 2014-10-15 4:17 ` Chanwoo Choi
2014-10-15 4:34 ` Jaewon Kim
0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2014-10-15 4:17 UTC (permalink / raw)
To: Jaewon Kim; +Cc: Dmitry Torokhov, linux-input
Hi Jaewon,
I think you better to use ':' instead of '-'.
- before: Input: misc: max77693-haptic -
- after : Input: misc: max77693-haptic:
On 10/15/2014 12:16 PM, Jaewon Kim wrote:
> In order to avoid duplicated execution, max77693_haptic_disable()
> check disable state. But it was reversed. this patch fix it.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> drivers/input/misc/max77693-haptic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/max77693-haptic.c b/drivers/input/misc/max77693-haptic.c
> index d605db4..7b1fde9 100644
> --- a/drivers/input/misc/max77693-haptic.c
> +++ b/drivers/input/misc/max77693-haptic.c
> @@ -152,7 +152,7 @@ static void max77693_haptic_disable(struct max77693_haptic *haptic)
> {
> int error;
>
> - if (haptic->enabled)
> + if (!haptic->enabled)
> return;
>
> error = max77693_haptic_configure(haptic, false);
>
If you modify patch name, Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Input: misc: max77693-haptic - fix active state check in disable()
2014-10-15 4:17 ` Chanwoo Choi
@ 2014-10-15 4:34 ` Jaewon Kim
2014-10-16 21:00 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Jaewon Kim @ 2014-10-15 4:34 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: Dmitry Torokhov, linux-input
Hi Chanwoo,
2014년 10월 15일 13:17에 Chanwoo Choi 이(가) 쓴 글:
> Hi Jaewon,
>
> I think you better to use ':' instead of '-'.
> - before: Input: misc: max77693-haptic -
> - after : Input: misc: max77693-haptic:
I refer past log message.
I think '-' is input driver style.
>
> On 10/15/2014 12:16 PM, Jaewon Kim wrote:
>> In order to avoid duplicated execution, max77693_haptic_disable()
>> check disable state. But it was reversed. this patch fix it.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>> ---
>> drivers/input/misc/max77693-haptic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/misc/max77693-haptic.c b/drivers/input/misc/max77693-haptic.c
>> index d605db4..7b1fde9 100644
>> --- a/drivers/input/misc/max77693-haptic.c
>> +++ b/drivers/input/misc/max77693-haptic.c
>> @@ -152,7 +152,7 @@ static void max77693_haptic_disable(struct max77693_haptic *haptic)
>> {
>> int error;
>>
>> - if (haptic->enabled)
>> + if (!haptic->enabled)
>> return;
>>
>> error = max77693_haptic_configure(haptic, false);
>>
> If you modify patch name, Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> Thanks,
> Chanwoo Choi
>
Thanks,
Jaewon Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Input: misc: max77693-haptic - fix active state check in disable()
2014-10-15 4:34 ` Jaewon Kim
@ 2014-10-16 21:00 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2014-10-16 21:00 UTC (permalink / raw)
To: Jaewon Kim; +Cc: Chanwoo Choi, linux-input
On Wed, Oct 15, 2014 at 01:34:31PM +0900, Jaewon Kim wrote:
> Hi Chanwoo,
>
>
> 2014년 10월 15일 13:17에 Chanwoo Choi 이(가) 쓴 글:
> >Hi Jaewon,
> >
> >I think you better to use ':' instead of '-'.
> >- before: Input: misc: max77693-haptic -
> >- after : Input: misc: max77693-haptic:
> I refer past log message.
> I think '-' is input driver style.
Yes, the input style is "Input: <driver> - <short change title>"
Applied, thank you.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-16 21:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-15 3:16 [PATCH] Input: misc: max77693-haptic - fix active state check in disable() Jaewon Kim
2014-10-15 4:17 ` Chanwoo Choi
2014-10-15 4:34 ` Jaewon Kim
2014-10-16 21:00 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).