Hp 3d driveguard seems to be sending events through the keyboard bus - should atkbd be modified to ignore that?

Hp 3d driveguard seems to be sending events through the keyboard bus - should atkbd be modified to ignore that?

[Giedrius Statkevicius]

Hello,
In some hp laptops there is a functionality called hp 3d driverguard
which is basically a accelerometer that detects free fall. It seems
that on some laptops a keyboard button press event is generated when
accelerometer's values change and ofc the scan code is not recognized
by atkbd (and it shouldn't be as it's not a real key). The result of
this is that the system log gets filled with these messages:

[ 9163.578181] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).
[ 9163.578189] atkbd serio0: Use 'setkeycodes e028 <keycode>' to make it known.

The range of scan codes seem to be from 0xa5 to 0xa8. In my opinion,
these scan codes on hp laptops with this future should definitely be
ignored because they are handled by the 'hp_accel' driver. For some
reason, the accelerometer sends the events through the keyboard bus too.

I've filled a bug report here:
https://bugzilla.kernel.org/show_bug.cgi?id=84941

What does everyone else think about ignoring these scan codes for
laptops with this particular feature?

Re: Hp 3d driveguard seems to be sending events through the keyboard bus - should atkbd be modified to ignore that?

[Dmitry Torokhov]

Hi Giedrius,

On Thu, Oct 16, 2014 at 07:05:01PM +0300, Giedrius Statkevicius wrote:
> Hello,
> In some hp laptops there is a functionality called hp 3d driverguard
> which is basically a accelerometer that detects free fall. It seems
> that on some laptops a keyboard button press event is generated when
> accelerometer's values change and ofc the scan code is not recognized
> by atkbd (and it shouldn't be as it's not a real key). The result of
> this is that the system log gets filled with these messages:
> 
> [ 9163.578181] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).
> [ 9163.578189] atkbd serio0: Use 'setkeycodes e028 <keycode>' to make it known.
> 
> The range of scan codes seem to be from 0xa5 to 0xa8. In my opinion,
> these scan codes on hp laptops with this future should definitely be
> ignored because they are handled by the 'hp_accel' driver. For some
> reason, the accelerometer sends the events through the keyboard bus too.
> 
> I've filled a bug report here:
> https://bugzilla.kernel.org/show_bug.cgi?id=84941
> 
> What does everyone else think about ignoring these scan codes for
> laptops with this particular feature?

hp_accel driver should use i8042_install_filter() to install a
filtering function that will remove accelerometer data from the keyboard
data stream.

Thanks.

-- 
Dmitry