From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?q?Roh=C3=A1r?= Subject: Re: [PATCH 1/3] input: alps: Reset mouse before identifying it Date: Sun, 19 Oct 2014 13:07:41 +0200 Message-ID: <201410191307.41313@pali> References: <1412329392-5580-1-git-send-email-pali.rohar@gmail.com> <201410152010.39507@pali> <20141015182256.GE8625@dtor-ws> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3145018.YlQBc0RxdZ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f181.google.com ([209.85.212.181]:55128 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbaJSLHp (ORCPT ); Sun, 19 Oct 2014 07:07:45 -0400 In-Reply-To: <20141015182256.GE8625@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Tommy Will , Hans de Goede , Yunkang Tang , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org --nextPart3145018.YlQBc0RxdZ Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 15 October 2014 20:22:56 Dmitry Torokhov wrote: > On Wed, Oct 15, 2014 at 08:10:39PM +0200, Pali Roh=C3=A1r wrote: > > On Wednesday 15 October 2014 20:00:11 Dmitry Torokhov wrote: > > > On Wed, Oct 15, 2014 at 07:57:37PM +0200, Pali Roh=C3=A1r wrote: > > > > On Wednesday 15 October 2014 19:43:15 Dmitry Torokhov=20 wrote: > > > > > On Wed, Oct 15, 2014 at 02:53:11PM +0200, Pali Roh=C3=A1r=20 wrote: > > > > > > On Tuesday 14 October 2014 08:08:34 Dmitry Torokhov > >=20 > > wrote: > > > > > > > On Fri, Oct 03, 2014 at 11:47:59AM +0200, Hans de > > > > > > > Goede > > > >=20 > > > > wrote: > > > > > > > > Hi, > > > > > > > >=20 > > > > > > > > Thanks for working on this! > > > > > > > >=20 > > > > > > > > On 10/03/2014 11:43 AM, Pali Roh=C3=A1r wrote: > > > > > > > > > On some systems after starting computer > > > > > > > > > function alps_identify() does not detect dual > > > > > > > > > ALPS touchpad+trackstick device correctly and > > > > > > > > > detect only touchpad. > > > > > > > > >=20 > > > > > > > > > Resetting ALPS device before identifiying it > > > > > > > > > fixing this problem and both parts touchpad > > > > > > > > > and trackstick are detected. > > > > > > > > >=20 > > > > > > > > > Signed-off-by: Pali Roh=C3=A1r > > > > > > > > > Tested-by: Pali Roh=C3=A1r > > > > > > > > > > > > > > > > >=20 > > > > > > > > Looks good and seems sensible: > > > > > > > >=20 > > > > > > > > Acked-by: Hans de Goede > > > > > > >=20 > > > > > > > *sigh* I am not really happy about this, as we > > > > > > > making boot longer and longer for people without > > > > > > > ALPS touchpads. It would be better if we only > > > > > > > reset the mouse when we knew we are dealing with > > > > > > > ALPS, and even better if we only reset it when we > > > > > > > suspected that we missed trackstick. Any chance > > > > > > > of doing this? > > > > > > >=20 > > > > > > > Thanks. > > > > > >=20 > > > > > > Dmitry, problem is that function check which > > > > > > detecting trackstick does not working when I start > > > > > > my laptop from power-off state and do not reset > > > > > > PS/2 device. But detecting ALPS touchpad looks like > > > > > > working. So if do not like this idea, what about > > > > > > doing something like this in alps_dectect function? > > > > > >=20 > > > > > > int alps_detect(...) > > > > > > { > > > > > > ... > > > > > > /* detect if device is ALPS */ > > > > > > if (alps_identify(...) < 0) > > > > > > return -1; > > > > > > /* now we know that device is ALPS */ > > > > > > if (!(flags & ALPS_DUALPOINT)) { > > > > > > /* reset it and identify again, maybe there is > > > > > > trackstick */ psmouse_reset(...); > > > > > > alps_identify(...); > > > > > > } > > > > > > ... > > > > > > } > > > > > >=20 > > > > > > It will does not affect non ALPS devices (because > > > > > > first identify call will fail), but will affect > > > > > > ALPS devices without trackstick (because identify > > > > > > will be called twice and reset too). > > > > >=20 > > > > > I think this is a step in right direction. Do you know > > > > > what exactly fails in alps_identify() on your box if > > > > > you do not call psmouse_reset? > > > > >=20 > > > > > Thanks. > > > >=20 > > > > Yes, I know. It is failing in > > > > alps_probe_trackstick_v3(). It calls > > > > alps_command_mode_read_reg(...) and it returns 0 which > > > > means trackstick is not there. > > >=20 > > > OK, so can we try sticking psmouse_reset() there? This > > > will limit the exposure of the new delay. > > >=20 > > > Thanks. > >=20 > > Sorry, but I think this is not safe. Function psmouse_reset > > will reset device (set it to relative mode, etc...) and > > before and after alps_probe_trackstick_v3() are called > > other functions. So it could break something else. >=20 > We might need to repeat bits of alps_identify() after > resetting the mouse, you are right. It should still be doable > though. What about checking "E6 report" and if that pass reset device and=20 do full alps_identify? With check for "E6 report" we can filter=20 probably all PS/2 devices which are not ALPS. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart3145018.YlQBc0RxdZ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlRDm30ACgkQi/DJPQPkQ1IqDgCgu1/fRMgKZ/BBMlLET+aNMhQp NWYAn2zDrY+4QV2gSNAWulr8QyiGKhGi =atxq -----END PGP SIGNATURE----- --nextPart3145018.YlQBc0RxdZ--