Re: [PATCH v2] hid-input: Map unknown consumer page codes to KEY_UNKNOWN

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Oct 21, 2014 at 11:11:00PM +0200, Hans de Goede wrote:
> Currently unknown consumer page codes are ignored, which means that they
> cannot later be mapped from userspace using udev / hwdb. Map them to
> KEY_UNKNOWN, so that userspace can remap them for keyboards which
> make up their own consumer page codes.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I think this makes sense. Thanks Hans.

> 
> --
> Changes in v2: Use key_map_clear rather then key_map
> ---
>  drivers/hid/hid-input.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 2619f7f..a6e33d3 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -856,7 +856,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>  		case 0x28b: map_key_clear(KEY_FORWARDMAIL);	break;
>  		case 0x28c: map_key_clear(KEY_SEND);		break;
>  
> -		default:    goto ignore;
> +		default: map_key_clear(KEY_UNKNOWN);
>  		}
>  		break;
>  
> -- 
> 2.1.0
> 

-- 
Dmitry