From: Daniel Walter <dwalter@google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
"kernel list" <linux-kernel@vger.kernel.org>,
sre@kernel.org, B38611@freescale.com, aaro.koskinen@iki.fi,
jg1.han@samsung.com, linux-input@vger.kernel.org
Subject: Re: 3.18.rc1: compile failure in tsc2005.c
Date: Thu, 23 Oct 2014 17:07:03 +0100 [thread overview]
Message-ID: <20141023160703.GA3230@google.com> (raw)
In-Reply-To: <20141023154751.GB18714@dtor-ws>
On Thu, Oct 23, 2014 at 08:47:51AM -0700, Dmitry Torokhov wrote:
> On Thu, Oct 23, 2014 at 03:01:04PM +0200, Pali Rohár wrote:
> > On Thursday 23 October 2014 14:53:25 Pavel Machek wrote:
> > > Hi!
> > >
> > > I get this. Before I start patching it, perhaps someone has
> > > fixed it already?
> > >
> > > Pavel
> > >
> > > CC drivers/input/touchscreen/tsc2005.o
> > > drivers/input/touchscreen/tsc2005.c: In function
> > > 'tsc2005_disable_store':
> > > drivers/input/touchscreen/tsc2005.c:406:2: error: implicit
> > > declaration of function 'strict_strtoul'
> > > [-Werror=implicit-function-declaration] cc1: some warnings
> > > being treated as errors
> > > scripts/Makefile.build:257: recipe for target
> > > 'drivers/input/touchscreen/tsc2005.o' failed
> > > make[3]: *** [drivers/input/touchscreen/tsc2005.o] Error 1
> > > scripts/Makefile.build:402: recipe for target
> > > 'drivers/input/touchscreen' failed
> > > make[2]: *** [drivers/input/touchscreen] Error 2
> > > scripts/Makefile.build:402: recipe for target 'drivers/input'
> > > failed make[1]: *** [drivers/input] Error 2
> > > make[1]: *** Waiting for unfinished jobs....
> > > CC net/core/request_sock.o
> >
> > Hi, I read somewhere that strict_strtoul function was replaced by
> > some kstrtol function... So maybe somebody forgot to fix tsc2005
> > driver?
>
> Yeah, I see patch from Daniel removing these but forgettign tsc2005.
>
> Pavel, if you have hardware then a patch connverting to kstro* would be
> very welcome.
>
> Thanks.
>
> --
> Dmitry
Hi Pavel,
what tree are you working with, since I do not see any reference to
strict_strto* in mainline,
thanks
--
Daniel
next prev parent reply other threads:[~2014-10-23 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 12:53 3.18.rc1: compile failure in tsc2005.c Pavel Machek
2014-10-23 13:01 ` Pali Rohár
2014-10-23 15:47 ` Dmitry Torokhov
2014-10-23 16:07 ` Daniel Walter [this message]
2014-10-23 16:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023160703.GA3230@google.com \
--to=dwalter@google.com \
--cc=B38611@freescale.com \
--cc=aaro.koskinen@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).