* 3.18.rc1: compile failure in tsc2005.c
@ 2014-10-23 12:53 Pavel Machek
2014-10-23 13:01 ` Pali Rohár
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Machek @ 2014-10-23 12:53 UTC (permalink / raw)
To: kernel list
Cc: dmitry.torokhov, sre, B38611, pali.rohar, aaro.koskinen, jg1.han,
linux-input
Hi!
I get this. Before I start patching it, perhaps someone has fixed it
already?
Pavel
CC drivers/input/touchscreen/tsc2005.o
drivers/input/touchscreen/tsc2005.c: In function
'tsc2005_disable_store':
drivers/input/touchscreen/tsc2005.c:406:2: error: implicit declaration
of function 'strict_strtoul' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
scripts/Makefile.build:257: recipe for target
'drivers/input/touchscreen/tsc2005.o' failed
make[3]: *** [drivers/input/touchscreen/tsc2005.o] Error 1
scripts/Makefile.build:402: recipe for target
'drivers/input/touchscreen' failed
make[2]: *** [drivers/input/touchscreen] Error 2
scripts/Makefile.build:402: recipe for target 'drivers/input' failed
make[1]: *** [drivers/input] Error 2
make[1]: *** Waiting for unfinished jobs....
CC net/core/request_sock.o
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 3.18.rc1: compile failure in tsc2005.c
2014-10-23 12:53 3.18.rc1: compile failure in tsc2005.c Pavel Machek
@ 2014-10-23 13:01 ` Pali Rohár
2014-10-23 15:47 ` Dmitry Torokhov
2014-10-23 16:42 ` Pavel Machek
0 siblings, 2 replies; 5+ messages in thread
From: Pali Rohár @ 2014-10-23 13:01 UTC (permalink / raw)
To: Pavel Machek
Cc: kernel list, dmitry.torokhov, sre, B38611, aaro.koskinen, jg1.han,
linux-input
[-- Attachment #1: Type: Text/Plain, Size: 1185 bytes --]
On Thursday 23 October 2014 14:53:25 Pavel Machek wrote:
> Hi!
>
> I get this. Before I start patching it, perhaps someone has
> fixed it already?
>
> Pavel
>
> CC drivers/input/touchscreen/tsc2005.o
> drivers/input/touchscreen/tsc2005.c: In function
> 'tsc2005_disable_store':
> drivers/input/touchscreen/tsc2005.c:406:2: error: implicit
> declaration of function 'strict_strtoul'
> [-Werror=implicit-function-declaration] cc1: some warnings
> being treated as errors
> scripts/Makefile.build:257: recipe for target
> 'drivers/input/touchscreen/tsc2005.o' failed
> make[3]: *** [drivers/input/touchscreen/tsc2005.o] Error 1
> scripts/Makefile.build:402: recipe for target
> 'drivers/input/touchscreen' failed
> make[2]: *** [drivers/input/touchscreen] Error 2
> scripts/Makefile.build:402: recipe for target 'drivers/input'
> failed make[1]: *** [drivers/input] Error 2
> make[1]: *** Waiting for unfinished jobs....
> CC net/core/request_sock.o
Hi, I read somewhere that strict_strtoul function was replaced by
some kstrtol function... So maybe somebody forgot to fix tsc2005
driver?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 3.18.rc1: compile failure in tsc2005.c
2014-10-23 13:01 ` Pali Rohár
@ 2014-10-23 15:47 ` Dmitry Torokhov
2014-10-23 16:07 ` Daniel Walter
2014-10-23 16:42 ` Pavel Machek
1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2014-10-23 15:47 UTC (permalink / raw)
To: Pali Rohár
Cc: Pavel Machek, kernel list, sre, B38611, aaro.koskinen, jg1.han,
linux-input, Daniel Walter
On Thu, Oct 23, 2014 at 03:01:04PM +0200, Pali Rohár wrote:
> On Thursday 23 October 2014 14:53:25 Pavel Machek wrote:
> > Hi!
> >
> > I get this. Before I start patching it, perhaps someone has
> > fixed it already?
> >
> > Pavel
> >
> > CC drivers/input/touchscreen/tsc2005.o
> > drivers/input/touchscreen/tsc2005.c: In function
> > 'tsc2005_disable_store':
> > drivers/input/touchscreen/tsc2005.c:406:2: error: implicit
> > declaration of function 'strict_strtoul'
> > [-Werror=implicit-function-declaration] cc1: some warnings
> > being treated as errors
> > scripts/Makefile.build:257: recipe for target
> > 'drivers/input/touchscreen/tsc2005.o' failed
> > make[3]: *** [drivers/input/touchscreen/tsc2005.o] Error 1
> > scripts/Makefile.build:402: recipe for target
> > 'drivers/input/touchscreen' failed
> > make[2]: *** [drivers/input/touchscreen] Error 2
> > scripts/Makefile.build:402: recipe for target 'drivers/input'
> > failed make[1]: *** [drivers/input] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > CC net/core/request_sock.o
>
> Hi, I read somewhere that strict_strtoul function was replaced by
> some kstrtol function... So maybe somebody forgot to fix tsc2005
> driver?
Yeah, I see patch from Daniel removing these but forgettign tsc2005.
Pavel, if you have hardware then a patch connverting to kstro* would be
very welcome.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 3.18.rc1: compile failure in tsc2005.c
2014-10-23 15:47 ` Dmitry Torokhov
@ 2014-10-23 16:07 ` Daniel Walter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Walter @ 2014-10-23 16:07 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Pali Rohár, Pavel Machek, kernel list, sre, B38611,
aaro.koskinen, jg1.han, linux-input
On Thu, Oct 23, 2014 at 08:47:51AM -0700, Dmitry Torokhov wrote:
> On Thu, Oct 23, 2014 at 03:01:04PM +0200, Pali Rohár wrote:
> > On Thursday 23 October 2014 14:53:25 Pavel Machek wrote:
> > > Hi!
> > >
> > > I get this. Before I start patching it, perhaps someone has
> > > fixed it already?
> > >
> > > Pavel
> > >
> > > CC drivers/input/touchscreen/tsc2005.o
> > > drivers/input/touchscreen/tsc2005.c: In function
> > > 'tsc2005_disable_store':
> > > drivers/input/touchscreen/tsc2005.c:406:2: error: implicit
> > > declaration of function 'strict_strtoul'
> > > [-Werror=implicit-function-declaration] cc1: some warnings
> > > being treated as errors
> > > scripts/Makefile.build:257: recipe for target
> > > 'drivers/input/touchscreen/tsc2005.o' failed
> > > make[3]: *** [drivers/input/touchscreen/tsc2005.o] Error 1
> > > scripts/Makefile.build:402: recipe for target
> > > 'drivers/input/touchscreen' failed
> > > make[2]: *** [drivers/input/touchscreen] Error 2
> > > scripts/Makefile.build:402: recipe for target 'drivers/input'
> > > failed make[1]: *** [drivers/input] Error 2
> > > make[1]: *** Waiting for unfinished jobs....
> > > CC net/core/request_sock.o
> >
> > Hi, I read somewhere that strict_strtoul function was replaced by
> > some kstrtol function... So maybe somebody forgot to fix tsc2005
> > driver?
>
> Yeah, I see patch from Daniel removing these but forgettign tsc2005.
>
> Pavel, if you have hardware then a patch connverting to kstro* would be
> very welcome.
>
> Thanks.
>
> --
> Dmitry
Hi Pavel,
what tree are you working with, since I do not see any reference to
strict_strto* in mainline,
thanks
--
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 3.18.rc1: compile failure in tsc2005.c
2014-10-23 13:01 ` Pali Rohár
2014-10-23 15:47 ` Dmitry Torokhov
@ 2014-10-23 16:42 ` Pavel Machek
1 sibling, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2014-10-23 16:42 UTC (permalink / raw)
To: Pali Rohár
Cc: kernel list, dmitry.torokhov, sre, B38611, aaro.koskinen, jg1.han,
linux-input
Hi!
Oops, ignore me, this is part of n900 changes that did not make it to
mainline.
> > I get this. Before I start patching it, perhaps someone has
> > fixed it already?
> >
> > CC drivers/input/touchscreen/tsc2005.o
> > drivers/input/touchscreen/tsc2005.c: In function
> > 'tsc2005_disable_store':
> > drivers/input/touchscreen/tsc2005.c:406:2: error: implicit
> > declaration of function 'strict_strtoul'
> > [-Werror=implicit-function-declaration] cc1: some warnings
> > being treated as errors
n> > scripts/Makefile.build:257: recipe for target
> > 'drivers/input/touchscreen/tsc2005.o' failed
> > make[3]: *** [drivers/input/touchscreen/tsc2005.o] Error 1
> > scripts/Makefile.build:402: recipe for target
> > 'drivers/input/touchscreen' failed
> > make[2]: *** [drivers/input/touchscreen] Error 2
> > scripts/Makefile.build:402: recipe for target 'drivers/input'
> > failed make[1]: *** [drivers/input] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > CC net/core/request_sock.o
>
> Hi, I read somewhere that strict_strtoul function was replaced by
> some kstrtol function... So maybe somebody forgot to fix tsc2005
> driver?
Yes.. there are four places in n900 patches that will need fixing.
This only applies to Pali's tree.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Pavel
commit 1f031685bd14a13242f78e7cc9cc1cd767aa3dbc
Author: Pavel <pavel@ucw.cz>
Date: Thu Oct 23 17:23:16 2014 +0200
Fix compilation by replacing strict_strtoul to kstrtoul
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/arch/arm/plat-omap/gpio-switch.c b/arch/arm/plat-omap/gpio-switch.c
index 394c45b..ceed4f3 100644
--- a/arch/arm/plat-omap/gpio-switch.c
+++ b/arch/arm/plat-omap/gpio-switch.c
@@ -197,7 +197,7 @@ static ssize_t gpio_sw_disable_store(struct device *dev,
struct gpio_switch *sw = dev_get_drvdata(dev);
unsigned long res;
- if (strict_strtoul(buf, 10, &res) < 0)
+ if (kstrtoul(buf, 10, &res) < 0)
return -EINVAL;
if (!!res == sw->disabled)
diff --git a/drivers/input/touchscreen/tsc2005.c b/drivers/input/touchscreen/tsc2005.c
index 422ec6e..ec1c276 100644
--- a/drivers/input/touchscreen/tsc2005.c
+++ b/drivers/input/touchscreen/tsc2005.c
@@ -403,7 +403,7 @@ static ssize_t tsc2005_disable_store(struct device *dev,
unsigned long val;
int error;
- error = strict_strtoul(buf, 10, &val);
+ error = kstrtoul(buf, 10, &val);
if (error)
return error;
diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c
index 3a986f3..f697e5f 100644
--- a/drivers/net/wireless/ti/wl1251/main.c
+++ b/drivers/net/wireless/ti/wl1251/main.c
@@ -1506,7 +1506,7 @@ static ssize_t wl1251_sysfs_store_tx_mgmt_frm_rate(struct device *dev,
unsigned long res;
int ret;
- ret = strict_strtoul(buf, 10, &res);
+ ret = kstrtoul(buf, 10, &res);
if (ret < 0) {
wl1251_warning("incorrect value written to tx_mgmt_frm_rate");
@@ -1600,7 +1600,7 @@ static ssize_t wl1251_sysfs_store_bt_coex_mode(struct device *dev,
unsigned long res;
int ret;
- ret = strict_strtoul(buf, 10, &res);
+ ret = kstrtoul(buf, 10, &res);
if (ret < 0) {
wl1251_warning("incorrect value written to bt_coex_mode");
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-23 16:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 12:53 3.18.rc1: compile failure in tsc2005.c Pavel Machek
2014-10-23 13:01 ` Pali Rohár
2014-10-23 15:47 ` Dmitry Torokhov
2014-10-23 16:07 ` Daniel Walter
2014-10-23 16:42 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).