* [PATCH] input: stmpe: fix valid key line bitmask
@ 2014-10-18 12:52 Linus Walleij
2014-10-24 21:37 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2014-10-18 12:52 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: Linus Walleij
The bitmask comment says it will enable GPIO 8-14 and 16-20
for keypad use, but it actually enables GPIO 8-11 and 13-20
due to a bit error.
Instead of masking of the "hole" at GPIO 12 (which is used
for keypad output 4) mask of the proper "hole" at GPIO 15.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Hi Dmitry, this is for fixes I think.
---
drivers/input/keyboard/stmpe-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/stmpe-keypad.c b/drivers/input/keyboard/stmpe-keypad.c
index c6727dda68f2..ef5e67fb567e 100644
--- a/drivers/input/keyboard/stmpe-keypad.c
+++ b/drivers/input/keyboard/stmpe-keypad.c
@@ -86,7 +86,7 @@ static const struct stmpe_keypad_variant stmpe_keypad_variants[] = {
.max_cols = 8,
.max_rows = 12,
.col_gpios = 0x0000ff, /* GPIO 0 - 7*/
- .row_gpios = 0x1fef00, /* GPIO 8-14, 16-20 */
+ .row_gpios = 0x1f7f00, /* GPIO 8-14, 16-20 */
},
[STMPE2403] = {
.auto_increment = true,
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] input: stmpe: fix valid key line bitmask
2014-10-18 12:52 [PATCH] input: stmpe: fix valid key line bitmask Linus Walleij
@ 2014-10-24 21:37 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2014-10-24 21:37 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-input
On Sat, Oct 18, 2014 at 02:52:09PM +0200, Linus Walleij wrote:
> The bitmask comment says it will enable GPIO 8-14 and 16-20
> for keypad use, but it actually enables GPIO 8-11 and 13-20
> due to a bit error.
>
> Instead of masking of the "hole" at GPIO 12 (which is used
> for keypad output 4) mask of the proper "hole" at GPIO 15.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Hi Dmitry, this is for fixes I think.
Applied, thank you.
> ---
> drivers/input/keyboard/stmpe-keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/stmpe-keypad.c b/drivers/input/keyboard/stmpe-keypad.c
> index c6727dda68f2..ef5e67fb567e 100644
> --- a/drivers/input/keyboard/stmpe-keypad.c
> +++ b/drivers/input/keyboard/stmpe-keypad.c
> @@ -86,7 +86,7 @@ static const struct stmpe_keypad_variant stmpe_keypad_variants[] = {
> .max_cols = 8,
> .max_rows = 12,
> .col_gpios = 0x0000ff, /* GPIO 0 - 7*/
> - .row_gpios = 0x1fef00, /* GPIO 8-14, 16-20 */
> + .row_gpios = 0x1f7f00, /* GPIO 8-14, 16-20 */
> },
> [STMPE2403] = {
> .auto_increment = true,
> --
> 1.9.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-24 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-18 12:52 [PATCH] input: stmpe: fix valid key line bitmask Linus Walleij
2014-10-24 21:37 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).