From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 00/15] new locomo driver Date: Tue, 28 Oct 2014 00:13:39 +0000 Message-ID: <20141028001338.GZ27405@n2100.arm.linux.org.uk> References: <1414454528-24240-1-git-send-email-dbaryshkov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1414454528-24240-1-git-send-email-dbaryshkov@gmail.com> Sender: linux-gpio-owner@vger.kernel.org To: Dmitry Eremin-Solenikov , Greg KH Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, Andrea Adami , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Linus Walleij , Alexandre Courbot , Dmitry Torokhov , Bryan Wu , Richard Purdie , Samuel Ortiz , Lee Jones , Mark Brown , Jingoo Han , Liam Girdwood List-Id: linux-input@vger.kernel.org On Tue, Oct 28, 2014 at 03:01:53AM +0300, Dmitry Eremin-Solenikov wrote: > Sharp Zaurus SL-5500 and SL-5600 use special companion Gate Array. Current > drivers present in Linux kernel has some problems: > > * It uses custom bus instead of platform bus/mfd core. I believe Greg wouldn't see that as a positive point. Don't think that the platform bus _should_ always be used. It shouldn't (Greg has said he'd like to see the platform bus to be totally killed off.) Instead, custom buses properly suited to the class of device in question is much preferred, especially if it aids in... > * Device drivers are not well layered/separated. ... better layering or separation of drivers. So, thinking that converting from a custom bus to a platform bus definitely is /not/ a positive step forward. (Why mfd was ever allowed to re-use the platform bus stuff is a separate question not relevent to these patches.) -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.