linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: i8042 - add mux quirk for HP EliteBook 8470p
@ 2014-10-28 19:48 Luis Henriques
  2014-10-28 20:10 ` Dmitry Torokhov
  0 siblings, 1 reply; 3+ messages in thread
From: Luis Henriques @ 2014-10-28 19:48 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, linux-kernel

This laptop requires active multiplexing to be enabled in order to be able
to separate the PS/2 mouse and the touchpad.

Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
 drivers/input/serio/i8042-x86ia64io.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index a0bcbb64d06d..34b95e4268eb 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -220,6 +220,13 @@ static const struct dmi_system_id __initconst i8042_dmi_mux_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "CF-18"),
 		},
 	},
+	{
+		/* HP EliteBook 8470p */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8470p"),
+		},
+	},
 	{ }
 };
 
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Input: i8042 - add mux quirk for HP EliteBook 8470p
  2014-10-28 19:48 [PATCH] Input: i8042 - add mux quirk for HP EliteBook 8470p Luis Henriques
@ 2014-10-28 20:10 ` Dmitry Torokhov
  2014-10-28 22:25   ` Luis Henriques
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2014-10-28 20:10 UTC (permalink / raw)
  To: Luis Henriques; +Cc: linux-input, linux-kernel

Hi Luis,

On Tue, Oct 28, 2014 at 07:48:24PM +0000, Luis Henriques wrote:
> This laptop requires active multiplexing to be enabled in order to be able
> to separate the PS/2 mouse and the touchpad.
> 
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
>  drivers/input/serio/i8042-x86ia64io.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index a0bcbb64d06d..34b95e4268eb 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -220,6 +220,13 @@ static const struct dmi_system_id __initconst i8042_dmi_mux_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "CF-18"),
>  		},
>  	},
> +	{
> +		/* HP EliteBook 8470p */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8470p"),

Hmm, so the tide is turning the other way ;) I think I'll be comfortable
extending this to all EliteBooks as I know 840 and 1040 work as well and
I have not heard any other complaints about this model line.

Cold you resend with match on "HP EliteBook" instead of "HP EliteBook
8470p"?

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Input: i8042 - add mux quirk for HP EliteBook 8470p
  2014-10-28 20:10 ` Dmitry Torokhov
@ 2014-10-28 22:25   ` Luis Henriques
  0 siblings, 0 replies; 3+ messages in thread
From: Luis Henriques @ 2014-10-28 22:25 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, linux-kernel

On Tue, Oct 28, 2014 at 01:10:46PM -0700, Dmitry Torokhov wrote:
> Hi Luis,
> 
> On Tue, Oct 28, 2014 at 07:48:24PM +0000, Luis Henriques wrote:
> > This laptop requires active multiplexing to be enabled in order to be able
> > to separate the PS/2 mouse and the touchpad.
> > 
> > Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> > ---
> >  drivers/input/serio/i8042-x86ia64io.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> > index a0bcbb64d06d..34b95e4268eb 100644
> > --- a/drivers/input/serio/i8042-x86ia64io.h
> > +++ b/drivers/input/serio/i8042-x86ia64io.h
> > @@ -220,6 +220,13 @@ static const struct dmi_system_id __initconst i8042_dmi_mux_table[] = {
> >  			DMI_MATCH(DMI_PRODUCT_NAME, "CF-18"),
> >  		},
> >  	},
> > +	{
> > +		/* HP EliteBook 8470p */
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8470p"),
> 
> Hmm, so the tide is turning the other way ;) I think I'll be comfortable
> extending this to all EliteBooks as I know 840 and 1040 work as well and
> I have not heard any other complaints about this model line.
> 
> Cold you resend with match on "HP EliteBook" instead of "HP EliteBook
> 8470p"?
> 

Sure, sending it in a minute.

Cheers,
--
Luís

> Thanks.
> 
> -- 
> Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-28 22:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-28 19:48 [PATCH] Input: i8042 - add mux quirk for HP EliteBook 8470p Luis Henriques
2014-10-28 20:10 ` Dmitry Torokhov
2014-10-28 22:25   ` Luis Henriques

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).