From: Richard Cochran <richardcochran@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Samuel Ortiz <sameo@linux.intel.com>,
Jan Kardell <jan.kardell@telliq.com>,
linux-iio@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Felipe Balbi <balbi@ti.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Meerwald <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-omap@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-arm
Subject: Re: [PATCH 0/4] Touchscreen performance related fixes
Date: Mon, 3 Nov 2014 19:09:21 +0100 [thread overview]
Message-ID: <20141103180920.GA20779@localhost.localdomain> (raw)
In-Reply-To: <1414408111-2631-1-git-send-email-vigneshr@ti.com>
On Mon, Oct 27, 2014 at 04:38:27PM +0530, Vignesh R wrote:
> This series of patches fix TSC defects related to lag in touchscreen
> performance and cursor jump at touch release. The lag was result of
> udelay in TSC interrupt handler. Cursor jump due to false pen-up event.
> The patches implement Advisory 1.0.31 in silicon errata of am335x-evm
> to avoid false pen-up events and remove udelay.
That advisory has two workarounds. You have chosen the second one?
The text of the second workaround says it only works on 4 wire setups,
so I wonder how 5 wire designs will be affected.
> The advisory says to use
> steps 1 to 4 for ADC and 5 to 16 for TSC (assuming 4 wire TSC and 4 channel
> ADC).
No, it doesn't say that. (sprz360f.pdf)
> Further the X co-ordinate must be the last one to be sampled just
> before charge step. The first two patches implement the required changes.
FWIW, I implemented the first workaround and removed the udelay not
too long ago. Like Sebastian, I saw the TSC unit hang after about
50000 interrupts when running with the workaround.
Did you test you patch for very long?
Thanks,
Richard
next prev parent reply other threads:[~2014-11-03 18:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 11:08 [PATCH 0/4] Touchscreen performance related fixes Vignesh R
2014-10-27 11:08 ` [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-10-31 21:03 ` Hartmut Knaack
2014-11-07 5:48 ` Vignesh R
2014-11-06 14:19 ` Richard Cochran
2014-11-07 5:34 ` Vignesh R
2014-11-07 8:00 ` Richard Cochran
2014-11-10 10:46 ` Vignesh R
[not found] ` <545C59CD.3070707-l0cyMroinI0@public.gmane.org>
2014-11-07 10:17 ` Richard Cochran
2014-10-27 11:08 ` [PATCH 2/4] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
[not found] ` <1414408111-2631-3-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-11-03 15:05 ` Lee Jones
2014-11-07 5:48 ` Vignesh R
2014-10-27 11:08 ` [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc Vignesh R
2014-10-31 21:09 ` Hartmut Knaack
2014-11-07 5:48 ` Vignesh R
2014-10-27 11:08 ` [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-10-27 17:34 ` [PATCH 0/4] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-10-27 19:02 ` Griffis, Brad
2014-11-03 12:17 ` Sebastian Andrzej Siewior
[not found] ` <54577258.9080508-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-11-04 11:44 ` Vignesh R
[not found] ` <5458BC0B.1040803-l0cyMroinI0@public.gmane.org>
2014-11-04 12:37 ` Sebastian Andrzej Siewior
[not found] ` <5458C87F.80409-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-11-05 12:08 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-03 18:09 ` Richard Cochran [this message]
[not found] ` <20141103180920.GA20779-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-06 7:42 ` Vignesh R
2014-11-12 13:00 ` Johannes Pointner
2014-11-13 12:23 ` Vignesh R
[not found] ` <5464A2B5.3020207-l0cyMroinI0@public.gmane.org>
2014-11-17 11:39 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103180920.GA20779@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jan.kardell@telliq.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).