From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 3/3] input: stmpe: bias keypad columns properly
Date: Mon, 3 Nov 2014 17:57:21 -0800 [thread overview]
Message-ID: <20141104015721.GA21814@dtor-ws> (raw)
In-Reply-To: <1413636999-3326-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
On Sat, Oct 18, 2014 at 02:56:39PM +0200, Linus Walleij wrote:
> + if (variant->set_pullup) {
> + u8 val;
> +
> + ret = stmpe_reg_read(stmpe, pureg);
> + if (ret)
> + return ret;
> +
> + /* Do not touch unused pins, may be used for GPIO */
> + val = ret & ~pu_pins;
> + val |= pu_pins;
> +
> + ret = stmpe_reg_write(stmpe, pureg, val);
Don't we need
if (ret) {
dev_err(...);
return ret;
}
here?
--
Dmitry
prev parent reply other threads:[~2014-11-04 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 12:56 [PATCH 3/3] input: stmpe: bias keypad columns properly Linus Walleij
2014-11-04 1:57 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104015721.GA21814@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).