linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ping Cheng <pinglinux@gmail.com>
Cc: Hans Petter Selasky <hps@selasky.org>,
	Denis Akiyakov <d.akiyakov@gmail.com>,
	linux-input <linux-input@vger.kernel.org>,
	"nox@jelal.kn-bremen.de >> Juergen Lock" <nox@jelal.kn-bremen.de>
Subject: Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD
Date: Tue, 4 Nov 2014 10:06:48 -0800	[thread overview]
Message-ID: <20141104180648.GA440@dtor-ws> (raw)
In-Reply-To: <CAF8JNhLPgG-dROf2f0Z6_8UBN7e_o_uicUDrO2sn+2yPgqdCmQ@mail.gmail.com>

On Tue, Nov 04, 2014 at 09:38:38AM -0800, Ping Cheng wrote:
> Hi Dmitry,
> 
> On Tue, Nov 4, 2014 at 12:08 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Sat, Nov 01, 2014 at 08:40:19AM +0100, Hans Petter Selasky wrote:
> >> On 11/01/14 00:27, Ping Cheng wrote:
> >> >If touch_input is NULL on FreeBSD, you need to figure out the root
> >> >cause. Checking on touch_input itself would not fix the root cause...
> >>
> >> Right.
> >>
> >> The root cause is that FreeBSD launches two instances of the driver,
> >> running in two different userland processes, for the two different
> >> Wacom interfaces on a common USB device. In Linux the wacom
> >> interface drivers are running from the same kernel, and can share
> >> the data in question, but in FreeBSD's webcamd emulation, this
> >> doesn't work. Then the first wacom probe call would have to grab the
> >> second interface.
> >>
> >> Technically speaking this is a FreeBSD only problem and I plan to
> >> deliver a patch with the webcamd software to fix this, like already
> >> suggested to you guys. This situation can also happen on Linux in
> >> case of a "BadUSB" device. That's why I think that the NULL check
> >> should be upstreamed.
> >
> > Hmm, looking at this again it seems that we just cross our fingers and
> > hope that both interfaces are enumerated by the time we get event data
> > from the device. I do not think this is quite safe. We probably should
> > be checking the overall state of probing (i.e. whether we are done
> > probing both interfaces) before processing data for the device.
> 
> Are you going to make a patch to address the issue?

Not in the nearest future, sorry.

> 
> > Or maybe we should just forcibly try claiming secondary interface
> > while probing primary instead of messing with shared data item.
> 
> If we incorporate the above idea into a patch, we need to keep in mind
> that not all tablets support touch data. So, not all tablets have two
> interfaces.

Right, but we do know the models that use multiple interfaces, right?

-- 
Dmitry

  reply	other threads:[~2014-11-04 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-18 10:56 Problems with Wacom Intuos PT M (CTH680) on FreeBSD Denis Akiyakov
2014-10-21 22:33 ` Dmitry Torokhov
2014-10-23  4:54   ` Denis Akiyakov
2014-10-23  5:54     ` Hans Petter Selasky
2014-10-31 23:27       ` Ping Cheng
2014-11-01  7:40         ` Hans Petter Selasky
2014-11-04  8:08           ` Dmitry Torokhov
2014-11-04 17:38             ` Ping Cheng
2014-11-04 18:06               ` Dmitry Torokhov [this message]
2014-11-07  1:30                 ` Ping Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141104180648.GA440@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=d.akiyakov@gmail.com \
    --cc=hps@selasky.org \
    --cc=linux-input@vger.kernel.org \
    --cc=nox@jelal.kn-bremen.de \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).