From: "Pali Rohár" <pali.rohar@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Yunkang Tang <yunkang.tang@cn.alps.com>,
Tommy Will <tommywill2011@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] Fixes for ALPS driver
Date: Thu, 6 Nov 2014 18:46:46 +0100 [thread overview]
Message-ID: <201411061846.48626@pali> (raw)
In-Reply-To: <54563C5F.10702@redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 1585 bytes --]
On Sunday 02 November 2014 15:14:55 Hans de Goede wrote:
> Hi,
>
> On 11/02/2014 12:25 AM, Pali Rohár wrote:
> > This patch series tries to fix problems with ALPS dualpoint
> > devices on Dell Latitude laptops which are probably caused
> > by bugs in Dell BIOS, Dell EC or in ALPS touchpad firmware
> > itself.
> >
> > Root of problems is yet unknown but at least this patch
> > series could eliminate reporting bogus data to userspace.
> >
> > Reported bugs:
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1258837
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1320022
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1272624
> > https://bugzilla.redhat.com/show_bug.cgi?id=1145954
> >
> > Pali Rohár (4):
> > input: alps: Do not try to parse data as 3 bytes packet
> > when driver
> >
> > is out of sync
> >
> > input: alps: Allow 2 invalid packets without resetting
> > device input: alps: For protocol V3, do not process data
> > when last packet's
> >
> > bit7 is set
> >
> > input: alps: Fix trackstick detection
> >
> > drivers/input/mouse/alps.c | 113
> > +++++++++++++++++++++++++++++++------------- 1 file
> > changed, 80 insertions(+), 33 deletions(-)
>
> Thanks for working on this, patches 1-3 are:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Patch 4 is too much work to review on a Sunday :), so I'll
> leave reviewing it to Dmitry.
>
> Regards,
>
> Hans
Dmitry, can you review v3 patches?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2014-11-06 17:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 9:43 [PATCH 0/3] input: alps: Fixes for ALPS driver Pali Rohár
2014-10-03 9:43 ` [PATCH 1/3] input: alps: Reset mouse before identifying it Pali Rohár
2014-10-03 9:47 ` Hans de Goede
2014-10-14 6:08 ` Dmitry Torokhov
2014-10-15 12:53 ` Pali Rohár
2014-10-15 17:43 ` Dmitry Torokhov
2014-10-15 17:57 ` Pali Rohár
2014-10-15 18:00 ` Dmitry Torokhov
2014-10-15 18:10 ` Pali Rohár
2014-10-15 18:22 ` Dmitry Torokhov
2014-10-19 11:07 ` Pali Rohár
2014-10-23 15:44 ` Dmitry Torokhov
2014-11-01 23:29 ` Pali Rohár
2014-10-03 9:43 ` [PATCH 2/3] input: alps: For protocol V3, do not process data when last packet's bit7 is set Pali Rohár
2014-10-03 9:51 ` Hans de Goede
2014-10-03 9:58 ` Pali Rohár
2014-10-03 10:01 ` Hans de Goede
2014-10-03 9:43 ` [PATCH 3/3] input: alps: Reset mouse and ALPS driver immediately after first invalid packet Pali Rohár
2014-10-03 9:55 ` Hans de Goede
2014-10-03 10:05 ` Pali Rohár
2014-10-03 10:18 ` Hans de Goede
2014-10-03 10:23 ` Pali Rohár
2014-10-03 11:03 ` Hans de Goede
2014-10-03 12:04 ` Hans de Goede
2014-11-01 23:25 ` [PATCH v3 0/4] Fixes for ALPS driver Pali Rohár
2014-11-01 23:25 ` [PATCH v3 1/4] input: alps: Do not try to parse data as 3 bytes packet when driver is out of sync Pali Rohár
2014-11-08 20:52 ` Dmitry Torokhov
2014-11-01 23:25 ` [PATCH v3 2/4] input: alps: Allow 2 invalid packets without resetting device Pali Rohár
2014-11-08 21:00 ` Dmitry Torokhov
2014-11-01 23:25 ` [PATCH v3 3/4] input: alps: For protocol V3, do not process data when last packet's bit7 is set Pali Rohár
2014-11-09 7:50 ` Dmitry Torokhov
2014-11-09 11:22 ` Pali Rohár
2014-11-09 20:34 ` Dmitry Torokhov
2014-11-10 9:18 ` Pali Rohár
2014-11-01 23:25 ` [PATCH v3 4/4] input: alps: Fix trackstick detection Pali Rohár
2014-11-09 8:05 ` Dmitry Torokhov
2014-11-09 11:30 ` Pali Rohár
2014-11-14 11:22 ` Pali Rohár
2014-11-14 19:41 ` Pali Rohár
2014-11-02 14:14 ` [PATCH v3 0/4] Fixes for ALPS driver Hans de Goede
2014-11-06 17:46 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411061846.48626@pali \
--to=pali.rohar@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tommywill2011@gmail.com \
--cc=yunkang.tang@cn.alps.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).