From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Corbet Subject: Re: [PATCH 1/1] Input: xpad - update docs to reflect current state Date: Fri, 7 Nov 2014 13:48:54 -0500 Message-ID: <20141107134854.56305dbb@lwn.net> References: <1415004836-22871-1-git-send-email-danieru.dressler@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1415004836-22871-1-git-send-email-danieru.dressler@gmail.com> Sender: linux-doc-owner@vger.kernel.org To: Daniel Dressler Cc: Dmitry Torokhov , Tommi Rantala , Ted Mielczarek , Paul Gortmaker , Frank Razenberg , Benjamin Valentin , Petr Sebor , Thomaz de Oliveira dos Reis , "open list:DOCUMENTATION" , open list , linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org On Mon, 3 Nov 2014 17:53:06 +0900 Daniel Dressler wrote: > The last time this documentation was accurate was > just over 8 years ago. In this time we've added > support for two new generations of Xbox console > controllers and dozens of third-party controllers. > > This patch unifies terminology and makes it explicit > which model of controller a sentence refers to. So this seems like a useful update, and I was looking at pulling it into the docs tree. But this hunk: > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > index 2ed7905..7e2e047 100644 > --- a/drivers/input/joystick/xpad.c > +++ b/drivers/input/joystick/xpad.c > @@ -40,8 +40,8 @@ > * > * TODO: > * - fine tune axes (especially trigger axes) > - * - fix "analog" buttons (reported as digital now) > - * - get rumble working > + * - add original xbox rumble pack support > + * - add xbox one rumble support > * - need USB IDs for other dance pads > * > * History: Seems like a different change that shouldn't be mixed up with the doc update. Send me a version without that change and, in the absence of complaints, I'll apply it. Thanks, jon