From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
GTA04 owners <gta04-owner@goldelico.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] Input: gpio_keys: Make sure wake-up buttons work.
Date: Fri, 7 Nov 2014 15:45:07 -0800 [thread overview]
Message-ID: <20141107234507.GB4439@dtor-ws> (raw)
In-Reply-To: <20141108103707.45bcc7e3@notabene.brown>
Hi Neil,
On Sat, Nov 08, 2014 at 10:37:07AM +1100, NeilBrown wrote:
>
>
> If a key is to be used for wake-up, we must not disable
> the interrupt during suspend.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
>
> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
> index 8c98e97f8e41..0b5e54ae343e 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -526,6 +526,8 @@ static int gpio_keys_setup_key(struct platform_device *pdev,
> */
> if (!button->can_disable)
> irqflags |= IRQF_SHARED;
> + if (button->wakeup)
> + irqflags |= IRQF_NO_SUSPEND;
No, enable_irq_wake() should be enough. I believe Rafael has fixed that
in the core, right?
>
> error = devm_request_any_context_irq(&pdev->dev, bdata->irq,
> isr, irqflags, desc, bdata);
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-11-07 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 23:37 [PATCH] Input: gpio_keys: Make sure wake-up buttons work NeilBrown
2014-11-07 23:45 ` Dmitry Torokhov [this message]
2014-11-08 0:00 ` NeilBrown
2014-11-08 0:49 ` Rafael J. Wysocki
2014-11-08 5:17 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107234507.GB4439@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gta04-owner@goldelico.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).