From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
GTA04 owners <gta04-owner@goldelico.com>
Subject: Re: [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded.
Date: Sat, 8 Nov 2014 12:36:58 -0800 [thread overview]
Message-ID: <20141108203658.GA40319@dtor-ws> (raw)
In-Reply-To: <20141108104015.635a7388@notabene.brown>
On Sat, Nov 08, 2014 at 10:40:15AM +1100, NeilBrown wrote:
>
>
> This button is treated as a wakeup source, so we need to initialise it
> correctly.
>
> Without the device_init_wakeup() call, dev->power.wakeup will
> be NULL, and pm_wakeup_event() will do nothing.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Applied, thank you.
>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index fb3b63b2f85c..8400a1a34d87 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -85,6 +85,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
> }
>
> platform_set_drvdata(pdev, pwr);
> + device_init_wakeup(&pdev->dev, true);
>
> return 0;
> }
--
Dmitry
prev parent reply other threads:[~2014-11-08 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 23:40 [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded NeilBrown
2014-11-08 20:36 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141108203658.GA40319@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gta04-owner@goldelico.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).