* [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded.
@ 2014-11-07 23:40 NeilBrown
2014-11-08 20:36 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: NeilBrown @ 2014-11-07 23:40 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, GTA04 owners
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
This button is treated as a wakeup source, so we need to initialise it
correctly.
Without the device_init_wakeup() call, dev->power.wakeup will
be NULL, and pm_wakeup_event() will do nothing.
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
index fb3b63b2f85c..8400a1a34d87 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -85,6 +85,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
}
platform_set_drvdata(pdev, pwr);
+ device_init_wakeup(&pdev->dev, true);
return 0;
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded.
2014-11-07 23:40 [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded NeilBrown
@ 2014-11-08 20:36 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2014-11-08 20:36 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-input, linux-kernel, GTA04 owners
On Sat, Nov 08, 2014 at 10:40:15AM +1100, NeilBrown wrote:
>
>
> This button is treated as a wakeup source, so we need to initialise it
> correctly.
>
> Without the device_init_wakeup() call, dev->power.wakeup will
> be NULL, and pm_wakeup_event() will do nothing.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Applied, thank you.
>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index fb3b63b2f85c..8400a1a34d87 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -85,6 +85,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
> }
>
> platform_set_drvdata(pdev, pwr);
> + device_init_wakeup(&pdev->dev, true);
>
> return 0;
> }
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-08 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-07 23:40 [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded NeilBrown
2014-11-08 20:36 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).