From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Date: Thu, 13 Nov 2014 10:25:40 +0000 Message-ID: <20141113102540.GJ24004@x1> References: <1415694844-11230-1-git-send-email-vigneshr@ti.com> <1415694844-11230-4-git-send-email-vigneshr@ti.com> <20141111122623.GA24004@x1> <71C24A547111EA4E84AE759B748D9EAE4B976C@DBDE04.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <71C24A547111EA4E84AE759B748D9EAE4B976C-yXqyApvAXouIQmiDNMet8wC/G2K4zDHf@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "R, Vignesh" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King , Jonathan Cameron , Hartmut Knaack , "richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , Dmitry Torokhov , Sebastian Andrzej Siewior , Lars-Peter Clausen , Peter Meerwald , Samuel Ortiz , "Balbi, Felipe" , "Griffis, Brad" , Sanjeev Sharma , Paul Gortmaker , Jan Kardell , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-input@vger.kernel.org On Tue, 11 Nov 2014, R, Vignesh wrote: > On Tue, 11 Nov 2014, Vignesh R wrote: > > In one shot mode, sequencer automatically disables all enabled step= s=20 > > at the end of each cycle. (both ADC steps and TSC steps) Hence thes= e=20 > > steps need not be saved in reg_se_cache for clearing these steps at= a=20 > > later stage. > > Also, when ADC wakes up Sequencer should not be busy executing any = of=20 > > the config steps except for the charge step. Previously charge step= =20 > > was 1 ADC clock cycle and hence it was ignored. > >=20 > > Signed-off-by: Vignesh R > > --- [...] > > - tsadc->reg_se_cache |=3D val; >=20 > You didn't answer my question about this? > I did reply to the question in the previous thread. =20 >=20 > Previously, TSC did not reliably re-enable its steps as the TSC irq h= andler received=20 > false pen up events. Hence, in order to use TSC after ADC operation, = it was necessary to > save and re-enable TSC steps (basically, to keep TSC steps enabled a= lways). > The change was more of a workaround to overcome limitation of TSC irq= handler. With=20 > this series of patches, TSC irq handler is very reliable and the work= around is no longer required. Okay, thanks for the explanation. By the way, your mailer doesn't appear to quote previous messages. Is there any way to fix that? > > am335x_tscadc_need_adc(tsadc); > > =20 > > tscadc_writel(tsadc, REG_SE, val); > > diff --git a/include/linux/mfd/ti_am335x_tscadc.h=20 > > b/include/linux/mfd/ti_am335x_tscadc.h > > index c99be5dc0f5c..fcce182e4a35 100644 > > --- a/include/linux/mfd/ti_am335x_tscadc.h > > +++ b/include/linux/mfd/ti_am335x_tscadc.h > > @@ -128,6 +128,7 @@ > > =20 > > /* Sequencer Status */ > > #define SEQ_STATUS BIT(5) > > +#define CHARGE_STEP 0x11 > > =20 > > #define ADC_CLK 3000000 > > #define TOTAL_STEPS 16 >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog