linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Benoit Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
	Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Sebastian Andrzej Siewior
	<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
	Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
	Brad Griffis <bgriffis-l0cyMroinI0@public.gmane.org>,
	Sanjeev Sharma
	<sanjeev_sharma-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
	Paul Gortmaker
	<paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>,
	Jan Kardell <jan.kardell-KSZdJiTw9mzQT0dZR+AlfA@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap@vger.k
Subject: Re: [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler
Date: Sat, 15 Nov 2014 20:27:39 +0100	[thread overview]
Message-ID: <20141115192739.GA18766@localhost.localdomain> (raw)
In-Reply-To: <1415941651-28962-3-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>

On Fri, Nov 14, 2014 at 10:37:27AM +0530, Vignesh R wrote:
> From: Brad Griffis <bgriffis-l0cyMroinI0@public.gmane.org>
> 
> TSC interrupt handler had udelay to avoid reporting of false pen-up
> interrupt to user space. This patch implements workaround suggesting in
> Advisory 1.0.31 of silicon errata for am335x, thus eliminating udelay
> and touchscreen lag. This also improves performance of touchscreen and
> eliminates sudden jump of cursor at touch release.

I back ported this series onto v3.15.1 in order to try this out on a
custom, beaglebone-like board. With this series, the touch is really
broken. (I had fixed the pen up problem in a totally different way for
a customer, and so I wanted to try out your solution.)

I will try to port the board code to a more recent kernel to try your
series again. With which kernel version did you test your patches?

And which board?

Thanks,
Richard

  parent reply	other threads:[~2014-11-15 19:27 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  5:07 [PATCH v4 0/6] Touchscreen performance related fixes Vignesh R
2014-11-14  5:07 ` [PATCH v4 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
     [not found] ` <1415941651-28962-1-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-11-14  5:07   ` [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
     [not found]     ` <1415941651-28962-3-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-11-15 19:27       ` Richard Cochran [this message]
     [not found]         ` <20141115192739.GA18766-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-17  4:27           ` Vignesh R
     [not found]             ` <54697919.5030302-l0cyMroinI0@public.gmane.org>
2014-11-17  8:23               ` Richard Cochran
     [not found]                 ` <20141117082337.GA3946-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-17 12:18                   ` Vignesh R
2014-11-14  5:07   ` [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2014-11-18 14:30     ` Lee Jones
2014-11-18 17:12       ` Dmitry Torokhov
2014-11-20 13:56         ` Sekhar Nori
     [not found]           ` <546DF2F0.9080405-l0cyMroinI0@public.gmane.org>
2014-11-20 14:23             ` Griffis, Brad
2014-11-20 14:34               ` Richard Cochran
2014-11-20 14:40             ` Richard Cochran
     [not found]               ` <20141120144028.GB5809-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-21 12:10                 ` Sekhar Nori
2014-11-21 13:10                   ` Richard Cochran
2014-11-21 15:11                     ` Johannes Pointner
     [not found]                       ` <CAJKbBDDVTA+=priRu7sCD=vHrC8AUg4DM3kycuGrqbpF-5FGAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21 15:37                         ` Sekhar Nori
2014-11-21 18:17                           ` Johannes Pointner
2014-11-21 21:40                             ` Richard Cochran
2014-11-21 22:25                               ` Griffis, Brad
2014-11-24  8:32                                 ` Johannes Pointner
     [not found]                     ` <20141121131036.GA18931-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-24  8:57                       ` Sebastian Andrzej Siewior
2014-11-24 10:01                         ` Richard Cochran
2014-11-14  5:07 ` [PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2014-11-14 18:03   ` Tony Lindgren
2014-11-14  5:07 ` [PATCH v4 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-11-14  5:07 ` [PATCH v4 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
2014-11-24 11:51 ` [PATCH v4 0/6] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-11-24 12:16   ` Vignesh R
2014-11-24 12:35     ` Sebastian Andrzej Siewior
     [not found]       ` <547325FA.6020004-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-11-27  4:29         ` Vignesh R
     [not found]   ` <20141124115116.GA14997-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-12-01  9:53     ` Vignesh R
     [not found]       ` <547C3A95.30605-l0cyMroinI0@public.gmane.org>
2014-12-01  9:59         ` Sebastian Andrzej Siewior
2014-12-01 10:29           ` Vignesh R
     [not found]             ` <547C42FF.5010700-l0cyMroinI0@public.gmane.org>
2014-12-11 20:34               ` Nicolae Rosia
2014-12-11 20:40                 ` Sebastian Andrzej Siewior
2014-12-12 13:48                   ` Vignesh R
2014-12-12 13:55                   ` Catalin Crenguta
2014-12-12 14:16                     ` Griffis, Brad
2014-12-15  7:55                       ` Catalin Crenguta
     [not found]                       ` <912A29987EAE174BA6CF187D7CDFA9CE26FA135A-YmePFLaaepqIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2014-12-15 12:45                         ` Catalin Crenguta
2014-12-16  8:31                         ` Catalin Crenguta
     [not found]                           ` <CABH3fy8S1Hb9LK=ZceWgJsNvLbq8pwu00Tcj_0vE4j6QzcO+kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-16 15:30                             ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141115192739.GA18766@localhost.localdomain \
    --to=richardcochran-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=bgriffis-l0cyMroinI0@public.gmane.org \
    --cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=jan.kardell-KSZdJiTw9mzQT0dZR+AlfA@public.gmane.org \
    --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
    --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-omap@vger.k \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=sanjeev_sharma-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=vigneshr-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).