* [PATCH] HID: i2c-hid: print the correct data in dbg msg
@ 2014-11-16 14:45 Antonio Borneo
2014-11-17 21:32 ` Benjamin Tissoires
2014-11-18 21:11 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Antonio Borneo @ 2014-11-16 14:45 UTC (permalink / raw)
To: Jiri Kosina, linux-input, Benjamin Tissoires
Cc: linux-kernel, Jean-Baptiste Maneyrol, Antonio Borneo
From: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
From: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Report is received in "buffer"; fix the following i2c_hid_dbg()
to dump data from the correct pointer.
Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
[Antonio Borneo: cleanup and rebase to v3.17]
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
---
drivers/hid/i2c-hid/i2c-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 747d544..933bf10 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -437,7 +437,7 @@ static void i2c_hid_init_report(struct hid_report *report, u8 *buffer,
report->id, buffer, size))
return;
- i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, ihid->inbuf);
+ i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, buffer);
ret_size = buffer[0] | (buffer[1] << 8);
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: i2c-hid: print the correct data in dbg msg
2014-11-16 14:45 [PATCH] HID: i2c-hid: print the correct data in dbg msg Antonio Borneo
@ 2014-11-17 21:32 ` Benjamin Tissoires
2014-11-18 21:11 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2014-11-17 21:32 UTC (permalink / raw)
To: Antonio Borneo
Cc: Jiri Kosina, linux-input, linux-kernel, Jean-Baptiste Maneyrol
On Nov 16 2014 or thereabouts, Antonio Borneo wrote:
> From: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
>
> From: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
>
> Report is received in "buffer"; fix the following i2c_hid_dbg()
> to dump data from the correct pointer.
>
> Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
> [Antonio Borneo: cleanup and rebase to v3.17]
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> ---
Good catch.
This one is Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/hid/i2c-hid/i2c-hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 747d544..933bf10 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -437,7 +437,7 @@ static void i2c_hid_init_report(struct hid_report *report, u8 *buffer,
> report->id, buffer, size))
> return;
>
> - i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, ihid->inbuf);
> + i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, buffer);
>
> ret_size = buffer[0] | (buffer[1] << 8);
>
> --
> 2.1.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: i2c-hid: print the correct data in dbg msg
2014-11-16 14:45 [PATCH] HID: i2c-hid: print the correct data in dbg msg Antonio Borneo
2014-11-17 21:32 ` Benjamin Tissoires
@ 2014-11-18 21:11 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2014-11-18 21:11 UTC (permalink / raw)
To: Antonio Borneo
Cc: linux-input, Benjamin Tissoires, linux-kernel,
Jean-Baptiste Maneyrol
On Sun, 16 Nov 2014, Antonio Borneo wrote:
> From: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
>
> Report is received in "buffer"; fix the following i2c_hid_dbg()
> to dump data from the correct pointer.
>
> Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
> [Antonio Borneo: cleanup and rebase to v3.17]
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Added Benjamin's Reviewed-by and applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-18 21:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-16 14:45 [PATCH] HID: i2c-hid: print the correct data in dbg msg Antonio Borneo
2014-11-17 21:32 ` Benjamin Tissoires
2014-11-18 21:11 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).