From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Felipe Balbi <balbi@ti.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Linux OMAP Mailing List" <linux-omap@vger.kernel.org>,
"Linux ARM Kernel Mailing List"
<linux-arm-kernel@lists.infradead.org>,
"Lothar Waßmann" <lw@karo-electronics.de>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 06/10] input: touchscreen: edt-ft5x06: fix driver autoprobing
Date: Tue, 18 Nov 2014 10:38:47 -0800 [thread overview]
Message-ID: <20141118183847.GE3003@dtor-ws> (raw)
In-Reply-To: <1416334028-7766-6-git-send-email-balbi@ti.com>
Hi Felipe,
On Tue, Nov 18, 2014 at 12:07:04PM -0600, Felipe Balbi wrote:
> i2c devices match against struct i2c_device_id
> even for CONFIG_OF case, so adding a struct of_device_id
> doesn't change anything. As a result, currently, edt-ft5x06
> will not autoprobe if built as a module.
Why doe snot it autoprobe? We properly declare MODULE_DEVICE_TABLE for
OF, is it because we are missing some data in device uevent?
>
> To fix the issue and still maintain backwards compatibility
> with all DTS files currently in tree, we're just moving
> all ids from of_device_id to i2c_device_id while also
> adding the following specific ids which should be used
> from now on:
>
> { "edt-ft5206", 0, }
> { "edt-ft5306", 0, }
> { "edt-ft5406", 0, }
Is this a tee-wide change? Link to the discussion?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-11-18 18:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416334028-7766-1-git-send-email-balbi@ti.com>
2014-11-18 18:07 ` [PATCH 06/10] input: touchscreen: edt-ft5x06: fix driver autoprobing Felipe Balbi
2014-11-18 18:38 ` Dmitry Torokhov [this message]
2014-11-18 19:09 ` Felipe Balbi
2014-11-18 19:21 ` Felipe Balbi
2014-11-18 19:27 ` [PATCH v2] " Felipe Balbi
2014-11-18 19:37 ` Felipe Balbi
2014-11-18 19:59 ` Dmitry Torokhov
2014-11-18 20:03 ` Felipe Balbi
2014-11-18 20:14 ` Dmitry Torokhov
2014-11-18 20:19 ` Felipe Balbi
2014-11-22 1:05 ` Felipe Balbi
2014-11-22 9:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118183847.GE3003@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lw@karo-electronics.de \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).