From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: scott <scott.liu@emc.com.tw>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Vincent Wang <vincent.wang@emc.com.tw>,
Jeff Chuang <jeff.chuang@emc.com.tw>,
Benson Leung <bleung@chromium.org>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>,
David Herrmann <dh.herrmann@gmail.com>
Subject: Re: [PATCH v1] Input: elants_i2c: Add Elan touchscreen support
Date: Thu, 20 Nov 2014 09:47:09 -0800 [thread overview]
Message-ID: <20141120174709.GA14798@dtor-glaptop> (raw)
In-Reply-To: <1416479490.28599.13.camel@linux-0dmf.site>
Hi Oliver,
On Thu, Nov 20, 2014 at 11:31:30AM +0100, Oliver Neukum wrote:
> > +static int elants_i2c_initialize(struct elants_data *ts)
> > +{
> > + struct i2c_client *client = ts->client;
> > + int error, retry_cnt;
> > + const u8 hello_packet[] = { 0x55, 0x55, 0x55, 0x55 };
> > + const u8 recov_packet[] = { 0x55, 0x55, 0x80, 0x80 };
> > + u8 buf[HEADER_SIZE];
> > +
>
> Strictly speaking you should disable preemption here.
Umm, why?
>
> > + for (retry_cnt = 0; retry_cnt < MAX_RETRIES; retry_cnt++) {
> > + error = elants_i2c_sw_reset(client);
> > + if (error) {
> > + /* Continue initializing if it's the last try
> > */
> > + if (retry_cnt < MAX_RETRIES - 1)
> > + continue;
> > + }
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-11-20 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 12:15 [PATCH v1] Input: elants_i2c: Add Elan touchscreen support scott
2014-11-20 8:11 ` Dmitry Torokhov
2014-11-20 8:55 ` ELAN 劉嘉駿
2014-11-20 10:31 ` Oliver Neukum
2014-11-20 12:25 ` ELAN 劉嘉駿
2014-11-20 17:51 ` 'Dmitry Torokhov'
2014-11-21 1:16 ` ELAN 劉嘉駿
2014-11-20 17:47 ` Dmitry Torokhov [this message]
2014-11-20 20:27 ` Oliver Neukum
2014-11-20 20:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120174709.GA14798@dtor-glaptop \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=bleung@chromium.org \
--cc=dh.herrmann@gmail.com \
--cc=jeff.chuang@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=rydberg@euromail.se \
--cc=scott.liu@emc.com.tw \
--cc=vincent.wang@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).