From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Vignesh R <vigneshr@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
richardcochran@gmail.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
Brad Griffis <bgriffis@ti.com>,
Sanjeev Sharma <sanjeev_sharma@mentor.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Jan Kardell <jan.kardell@telliq.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kerne
Subject: Re: [PATCH v4 0/6] Touchscreen performance related fixes
Date: Mon, 24 Nov 2014 12:51:16 +0100 [thread overview]
Message-ID: <20141124115116.GA14997@linutronix.de> (raw)
In-Reply-To: <1415941651-28962-1-git-send-email-vigneshr@ti.com>
* Vignesh R | 2014-11-14 10:37:25 [+0530]:
>This series of patches fix TSC defects related to lag in touchscreen
>performance and cursor jump at touch release. The lag was result of
>udelay in TSC interrupt handler. Cursor jump due to false pen-up event.
>The patches implement Advisory 1.0.31 in silicon errata of am335x-evm
am335x not -evm. The am335x-evm is a board (with its own advisory
document) built around the SoC.
Just testing the v4. I can use now IIO and touchscren at the same time.
back at v1 I reported that it does not work, this has been fixed now.
I had it running for a few minutes, now I see one of WARN_ON() beeing
triggered (I've cut a few numbers so don't wonder about PID 2 and so on):
|dmesg |grep WARNING | wc -l
|10
| dmesg |grep WARNING
|[306.257995] WARNING: CPU: 0 PID: 97 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[365.469591] WARNING: CPU: 0 PID: 58 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[379.255904] WARNING: CPU: 0 PID: 24 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[426.230505] WARNING: CPU: 0 PID: 35 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[435.654091] WARNING: CPU: 0 PID: 28 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[438.897519] WARNING: CPU: 0 PID: 91 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[525.720193] WARNING: CPU: 0 PID: 88 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[527.644770] WARNING: CPU: 0 PID: 38 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[557.218349] WARNING: CPU: 0 PID: 56 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
|[610.077274] WARNING: CPU: 0 PID: 2 at mfd/ti_am335x_tscadc.c:94 am335x_tsc_se_set_once+0xf8/0x104
The complete trace:
|[610.110692] CPU: 0 PID: 4422 Comm: cat Tainted: G W 3.18.0-rc6+ #1745
|[610.118577] [<c00138ec>] (unwind_backtrace) from [<c0011544>] (show_stack+0x10/0x14)
|[610.126772] [<c0011544>] (show_stack) from [<c003c9b0>] (warn_slowpath_common+0x68/0x88)
|[610.135313] [<c003c9b0>] (warn_slowpath_common) from [<c003c9ec>] (warn_slowpath_null+0x1c/0x24)
|[610.144586] [<c003c9ec>] (warn_slowpath_null) from [<bf00569c>] (am335x_tsc_se_set_once+0xf8/0x104 [ti_am335x_tscadc])
|[610.155886] [<bf00569c>] (am335x_tsc_se_set_once [ti_am335x_tscadc]) from [<bf067494>] (tiadc_read_raw+0xbc/0x190 [ti_am335x_adc])
|[610.168326] [<bf067494>] (tiadc_read_raw [ti_am335x_adc]) from [<bf02dccc>] (iio_read_channel_info+0x9c/0xa4 [industrialio])
|[610.180191] [<bf02dccc>] (iio_read_channel_info [industrialio]) from [<c02a42d4>] (dev_attr_show+0x1c/0x48)
|[610.190477] [<c02a42d4>] (dev_attr_show) from [<c013d544>] (sysfs_kf_seq_show+0x8c/0x110)
|[610.199108] [<c013d544>] (sysfs_kf_seq_show) from [<c013c1c8>] (kernfs_seq_show+0x24/0x28)
|[610.207833] [<c013c1c8>] (kernfs_seq_show) from [<c0102658>] (seq_read+0x1b4/0x47c)
|[610.215922] [<c0102658>] (seq_read) from [<c00e6700>] (vfs_read+0x8c/0x148)
|[610.223269] [<c00e6700>] (vfs_read) from [<c00e67fc>] (SyS_read+0x40/0x8c)
|[610.230525] [<c00e67fc>] (SyS_read) from [<c000e640>] (ret_fast_syscall+0x0/0x30)
Could you please look at that one? (I tested it on am335x-evm btw).
Sebastian
next prev parent reply other threads:[~2014-11-24 11:51 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 5:07 [PATCH v4 0/6] Touchscreen performance related fixes Vignesh R
2014-11-14 5:07 ` [PATCH v4 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
[not found] ` <1415941651-28962-1-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-11-14 5:07 ` [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
[not found] ` <1415941651-28962-3-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-11-15 19:27 ` Richard Cochran
[not found] ` <20141115192739.GA18766-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-17 4:27 ` Vignesh R
[not found] ` <54697919.5030302-l0cyMroinI0@public.gmane.org>
2014-11-17 8:23 ` Richard Cochran
[not found] ` <20141117082337.GA3946-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-17 12:18 ` Vignesh R
2014-11-14 5:07 ` [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2014-11-18 14:30 ` Lee Jones
2014-11-18 17:12 ` Dmitry Torokhov
2014-11-20 13:56 ` Sekhar Nori
[not found] ` <546DF2F0.9080405-l0cyMroinI0@public.gmane.org>
2014-11-20 14:23 ` Griffis, Brad
2014-11-20 14:34 ` Richard Cochran
2014-11-20 14:40 ` Richard Cochran
[not found] ` <20141120144028.GB5809-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-21 12:10 ` Sekhar Nori
2014-11-21 13:10 ` Richard Cochran
2014-11-21 15:11 ` Johannes Pointner
[not found] ` <CAJKbBDDVTA+=priRu7sCD=vHrC8AUg4DM3kycuGrqbpF-5FGAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21 15:37 ` Sekhar Nori
2014-11-21 18:17 ` Johannes Pointner
2014-11-21 21:40 ` Richard Cochran
2014-11-21 22:25 ` Griffis, Brad
2014-11-24 8:32 ` Johannes Pointner
[not found] ` <20141121131036.GA18931-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-24 8:57 ` Sebastian Andrzej Siewior
2014-11-24 10:01 ` Richard Cochran
2014-11-14 5:07 ` [PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2014-11-14 18:03 ` Tony Lindgren
2014-11-14 5:07 ` [PATCH v4 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-11-14 5:07 ` [PATCH v4 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
2014-11-24 11:51 ` Sebastian Andrzej Siewior [this message]
2014-11-24 12:16 ` [PATCH v4 0/6] Touchscreen performance related fixes Vignesh R
2014-11-24 12:35 ` Sebastian Andrzej Siewior
[not found] ` <547325FA.6020004-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-11-27 4:29 ` Vignesh R
[not found] ` <20141124115116.GA14997-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-12-01 9:53 ` Vignesh R
[not found] ` <547C3A95.30605-l0cyMroinI0@public.gmane.org>
2014-12-01 9:59 ` Sebastian Andrzej Siewior
2014-12-01 10:29 ` Vignesh R
[not found] ` <547C42FF.5010700-l0cyMroinI0@public.gmane.org>
2014-12-11 20:34 ` Nicolae Rosia
2014-12-11 20:40 ` Sebastian Andrzej Siewior
2014-12-12 13:48 ` Vignesh R
2014-12-12 13:55 ` Catalin Crenguta
2014-12-12 14:16 ` Griffis, Brad
2014-12-15 7:55 ` Catalin Crenguta
[not found] ` <912A29987EAE174BA6CF187D7CDFA9CE26FA135A-YmePFLaaepqIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2014-12-15 12:45 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
[not found] ` <CABH3fy8S1Hb9LK=ZceWgJsNvLbq8pwu00Tcj_0vE4j6QzcO+kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-16 15:30 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124115116.GA14997@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bgriffis@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jan.kardell@telliq.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sanjeev_sharma@mentor.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).