* [PATCH v2] Drivers: input: mousedev.c: Fixed trailing statement on the next line
@ 2014-12-01 12:36 Athira Sharikkal
2014-12-02 23:04 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Athira Sharikkal @ 2014-12-01 12:36 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Athira Sharikkal
Fixed checkpatch error:
trailing statements should be on next line
Signed-off-by: Athira Sharikkal <athirasnamby@gmail.com>
---
v2: corrected indentation
drivers/input/mousedev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index b604564..28988f5 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -248,7 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
case BTN_4:
case BTN_EXTRA: index = 4; break;
- default: return;
+ default:
+ return;
}
if (value) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] Drivers: input: mousedev.c: Fixed trailing statement on the next line
2014-12-01 12:36 [PATCH v2] Drivers: input: mousedev.c: Fixed trailing statement on the next line Athira Sharikkal
@ 2014-12-02 23:04 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2014-12-02 23:04 UTC (permalink / raw)
To: Athira Sharikkal; +Cc: linux-input, linux-kernel
Hi Athira,
On Mon, Dec 01, 2014 at 06:06:42PM +0530, Athira Sharikkal wrote:
> Fixed checkpatch error:
> trailing statements should be on next line
>
> Signed-off-by: Athira Sharikkal <athirasnamby@gmail.com>
> ---
> v2: corrected indentation
> drivers/input/mousedev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
> index b604564..28988f5 100644
> --- a/drivers/input/mousedev.c
> +++ b/drivers/input/mousedev.c
> @@ -248,7 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
> case BTN_4:
> case BTN_EXTRA: index = 4; break;
>
> - default: return;
> + default:
> + return;
Changing one bit in a file while leaving the rest of it unchanged does not
make much sense. That said, I believe that in this particular case the
original style is fine and does not need changing.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-03 5:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-01 12:36 [PATCH v2] Drivers: input: mousedev.c: Fixed trailing statement on the next line Athira Sharikkal
2014-12-02 23:04 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).